Activity log for bug #1252490

Date Who What changed Old value New value Message
2013-11-18 22:05:17 Pupu Toivonen bug added bug
2013-11-18 22:10:13 Pupu Toivonen description The Uncrustify Code Beautifier tool systematically aligns variable names, although it might not be reasonable in all places. struct sockaddr_in6 hipfw_addr; -int n = 0; +int n = 0; There is the variable align_var_def_thres in Uncrustify config file, which can be used to set an upper bound for how many spaces can be used for aligning. Also there is a known bug in Uncrustify (http://sourceforge.net/p/uncrustify/bugs/522/) that causes it to mistake a special case of variable definitions (a static pointer to an array of function pointers) for a function call, and apply rules related to function calls instead of rules related to variable definitions. -static int (*action_handler[])(struct hip_common *, int action, +static int(*action_handler[]) (struct hip_common *, int action, const char *opt[], int optc, int send_only) = { The Uncrustify Code Beautifier tool systematically aligns variable names, although it might not be reasonable in all places. ```  struct sockaddr_in6 hipfw_addr; -int n = 0; +int n = 0; ``` There is the variable align_var_def_thres in Uncrustify config file, which can be used to set an upper bound for how many spaces can be used for aligning. Also there is a known bug in Uncrustify (http://sourceforge.net/p/uncrustify/bugs/522/) that causes it to mistake a special case of variable definitions (a static pointer to an array of function pointers) for a function call, and apply rules related to function calls instead of rules related to variable definitions. ``` -static int (*action_handler[])(struct hip_common *, int action, +static int(*action_handler[]) (struct hip_common *, int action,                                 const char *opt[], int optc, int send_only) = { ```
2013-11-18 22:11:41 Pupu Toivonen description The Uncrustify Code Beautifier tool systematically aligns variable names, although it might not be reasonable in all places. ```  struct sockaddr_in6 hipfw_addr; -int n = 0; +int n = 0; ``` There is the variable align_var_def_thres in Uncrustify config file, which can be used to set an upper bound for how many spaces can be used for aligning. Also there is a known bug in Uncrustify (http://sourceforge.net/p/uncrustify/bugs/522/) that causes it to mistake a special case of variable definitions (a static pointer to an array of function pointers) for a function call, and apply rules related to function calls instead of rules related to variable definitions. ``` -static int (*action_handler[])(struct hip_common *, int action, +static int(*action_handler[]) (struct hip_common *, int action,                                 const char *opt[], int optc, int send_only) = { ``` The Uncrustify Code Beautifier tool systematically aligns variable names, although it might not be reasonable in all places.  struct sockaddr_in6 hipfw_addr; -int n = 0; +int n = 0; There is the variable align_var_def_thres in Uncrustify config file, which can be used to set an upper bound for how many spaces can be used for aligning. Also there is a known bug in Uncrustify (http://sourceforge.net/p/uncrustify/bugs/522/) that causes it to mistake a special case of variable definitions (a static pointer to an array of function pointers) for a function call, and apply rules related to function calls instead of rules related to variable definitions. -static int (*action_handler[])(struct hip_common *, int action, +static int(*action_handler[]) (struct hip_common *, int action,                                 const char *opt[], int optc, int send_only) = {
2013-11-22 12:16:02 Pupu Toivonen summary Alignment issues with uncrustify Issues with uncrustify
2013-11-22 12:18:18 Pupu Toivonen description The Uncrustify Code Beautifier tool systematically aligns variable names, although it might not be reasonable in all places.  struct sockaddr_in6 hipfw_addr; -int n = 0; +int n = 0; There is the variable align_var_def_thres in Uncrustify config file, which can be used to set an upper bound for how many spaces can be used for aligning. Also there is a known bug in Uncrustify (http://sourceforge.net/p/uncrustify/bugs/522/) that causes it to mistake a special case of variable definitions (a static pointer to an array of function pointers) for a function call, and apply rules related to function calls instead of rules related to variable definitions. -static int (*action_handler[])(struct hip_common *, int action, +static int(*action_handler[]) (struct hip_common *, int action,                                 const char *opt[], int optc, int send_only) = { The Uncrustify Code Beautifier tool systematically aligns variable names, although it might not be reasonable in all places.  struct sockaddr_in6 hipfw_addr; -int n = 0; +int n = 0; There is the variable align_var_def_thres in Uncrustify config file, which can be used to set an upper bound for how many spaces can be used for aligning. I found no configuration item in Uncrustify for forcing spaces between struct name and "{": i.e. to catch: typedef struct NetlinkList{ and turn it into: typedef struct NetlinkList { Also there is a known bug in Uncrustify (http://sourceforge.net/p/uncrustify/bugs/522/) that causes it to mistake a special case of variable definitions (a static pointer to an array of function pointers) for a function call, and apply rules related to function calls instead of rules related to variable definitions. -static int (*action_handler[])(struct hip_common *, int action, +static int(*action_handler[]) (struct hip_common *, int action,                                 const char *opt[], int optc, int send_only) = {