Underscore is not visible in the feed with certain settings

[Jarno Suni]

[Impact]

 * Using monospace fonts, some parts of the glyphs might not be visible
   (this is especially evident using some monospsace fonts, there the
   underscore is not visible).

 * This came due to a change in behaviour in Pango 1.44.
 * The fix makes use of a newer API for Pango>=1.44 that address this
   issue.

[Test Plan]

Select Monospace 9 font in appearance settings of hexchat.
Write something containing '_' in an irc channel.
Check, if the '_' is visible in the feed.

[Where problems could occur]

 * Messing this patch up means text wouldn't appear in the textbox
   anymore. so…

[Other Info]

 * None here.

[ Original report ]

If I have Monospace 9 (default?) as the font in HexChat settings I can not see underscore character '_' in the feed, but if I set it Monospace 10 and set Custom DPI setting in Xfce's Appearance dialog to 94 or smaller, I see the character.

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: hexchat 2.14.3-3
ProcVersionSignature: Ubuntu 5.4.0-67.75-generic 5.4.94
Uname: Linux 5.4.0-67-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.20.11-0ubuntu27.16
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: XFCE
Date: Tue Mar 23 18:52:59 2021
InstallationDate: Installed on 2020-05-03 (324 days ago)
InstallationMedia: Xubuntu Core 20.04 - amd64 - 20200423
SourcePackage: hexchat
UpgradeStatus: No upgrade log present (probably fresh install)

[Mattia Rizzolo (mapreri)]

This was fixed in hexchat/2.14.3-5; affected release is probably only focal right now.

[Mattia Rizzolo (mapreri)]

This is the fixing patch: https://salsa.debian.org/debian/hexchat/-/commit/a5687dbd864d495d01f8c1a054f5830bc1127ada

[Mattia Rizzolo (mapreri)]

Here is a fixing debdiff.

Now, the "problem" is that I don't seem to match the conditions to trigger this bug myself, so I'm unable to verify if it actually works.

If somebody is affected, please fill in the "Test plan" section of the description, and if you could also verify that the package available in my ppa https://launchpad.net/~mapreri/+archive/ubuntu/ppa fixes it for you, then I'll copy it over to the main archive.

[Jarno Suni (jarnos)]

The package available in the PPA fixed the issue.

[Mattia Rizzolo (mapreri)]

Very well, thank you.

I uploaded the package to ubuntu focal-proposed, and it's now pending review from the Stable Release Team.

You'll asked to test again using the package from focal-prosed later on. Unfortunately I forgot to use a different version in my PPA, so please pay attention that you `apt-get install --reinstall hexchat` when you will.

Thank you.

[Brian Murray (brian-murray)]

Hello Jarno, or anyone else affected,

Accepted hexchat into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/hexchat/2.14.3-3ubuntu0.20.04.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Paul White (paulw2u)]

In my focal installation I verified the reported bug - the underscore character was not visible 'in the feed'.

I enabled -proposed and upgraded my hexchat packages to version 2.14.3-3ubuntu0.20.04.2 and followed the test plan as per the bug description.

When using the 'Monospace 9' font (and my default of 'Monospace 10') I saw that the underscore character was now visible 'in the feed'.

Marking the focal task as verified.

[Launchpad Janitor (janitor)]

This bug was fixed in the package hexchat - 2.14.3-3ubuntu0.20.04.2

---------------
hexchat (2.14.3-3ubuntu0.20.04.2) focal; urgency=medium

  * Apply patch from upstream to fix font height calculation with Pango >= 1.44.
    Backported from 2.14.3-5. LP: #1920974

 -- Mattia Rizzolo <email address hidden> Mon, 04 Oct 2021 13:53:19 +0200

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for hexchat has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.