Option "get all" in Add Layer --> Time Step crashes

Bug #1257324 reported by Jens Rodmann
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Helioviewer.org
Fix Released
Critical
Jeff Stys
JHelioviewer
Confirmed
Undecided
Unassigned

Bug Description

When adding another layer ("Add Layer") and selecting "get all" from the Time Step, the user gets the following error message:

Error getting the data
Invalid cadence specified. Cadence must be greather than 0.

Proposed solution:
JHelioviewer should set the cadence to the smallest possible value.

Thanks for having a look at this one...

Jens Rodmann

Revision history for this message
Keith Hughitt (keith-hughitt) wrote :

Thanks for reporting the issue! It should also be possible to fix this from Helioviewer.org's side just have anything less than or equal to 0 return all images in the range.

Revision history for this message
Daniel Mueller (dmueller-esa) wrote :

The current release of JHV sends a "cadence=-1" in the API request if a user selects "get all" as cadence. However, this does not work with the API as-is ("Error getting the data. Invalid cadence specified. Cadence must be greather than 0.").

@Jeff: Could you maybe modify the API to make 'cadence=-1' work, e.g. by having the API return all images if cadence <= 0 ?

Changed in helioviewer.org:
status: New → Confirmed
Changed in jhelioviewer:
status: New → Confirmed
Changed in helioviewer.org:
assignee: nobody → Jeff Stys (jstys-z)
Revision history for this message
Jeff Stys (jstys-z) wrote :

I have updated the 'getJPX ' API action to accept 'cadence' parameter values <= 0.

The cadence gets set to 1 second internally, which effectively means return all available images.

If this results in a calculated number of frames that exceeds HV_MAX_JPX_FRAMES, then the cadence is automatically re-calculated to fit within HV_MAX_JPX_FRAMES. Note that HV_MAX_JPX_FRAMES is currently defined as in the settings/Config.ini file as:

    max_jpx_frames = 1000

Please let me know if this resolves the issue.

Jeff Stys (jstys-z)
Changed in helioviewer.org:
importance: Undecided → Critical
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.