Link generation and pop-up windows

Bug #1180805 reported by Jack Ireland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Helioviewer.org
Fix Committed
High
Jeff Stys

Bug Description

 - link button did not work after popping up a sunspot pop-up window.
 example: go back one year, click on the sunspot marker to pop up a window, close the window, and then
 click the link button
 also, if the link button is pressed before the sunpot pop-up window is launched, then the link button
 works as expected even after a pop-up window is launched.

Changed in helioviewer.org:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Jeff Stys (jstys-z)
Revision history for this message
Jeff Stys (jstys-z) wrote :

This is a pre-existing bug, unrelated to the F/E implementation in development. The behavior described below can be reproduced with the production code on Helioviewer.org:

The failure of the link button can be traced to an undefined date being passed into Date.parseUTCDate().
This occurs when the array of image tile layers in the TileLayerManager is empty (all tile layer accordions have been removed from the UI).

The getMiddleObservationTime() method currently only handles cases where there are 1 or more image tile layers selected. It attempts to access the date corresponding to the first element in an empty array and then passes that undefined value to Date.parseUTCDate() which throws an exception.

Revision history for this message
Jeff Stys (jstys-z) wrote :

+ Updated HeliovewerWebClient.js::getMiddleObservationTime() in the HEK development code to use the value of requestDate when no image tile layers are enabled.

Changed in helioviewer.org:
status: Triaged → Fix Committed
Changed in helioviewer.org:
milestone: none → 2.4.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.