prepare_for_replace() is not protected by a lock
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Heat |
Fix Released
|
High
|
Zane Bitter | ||
Pike |
Fix Committed
|
High
|
Zane Bitter | ||
Queens |
Fix Released
|
High
|
Zane Bitter |
Bug Description
Since https:/
In the case where UpdateReplace is raised from handle_update(), it seems clear that we should just call prepare_for_replace before releasing the lock.
In the case where UpdateReplace is raised before we actually take the lock, we should probably take the lock for the duration of the prepare_
tags: | added: pike-backport-potential |
Changed in heat: | |
assignee: | Zane Bitter (zaneb) → Rabi Mishra (rabi) |
Fix proposed to branch: master /review. openstack. org/516459
Review: https:/