Not handling unicode when serialising exceptions

Bug #1692693 reported by Zane Bitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Zane Bitter
Ocata
Fix Committed
High
Thomas Herve
Pike
Fix Released
High
Zane Bitter

Bug Description

The Ocata patch https://git.openstack.org/cgit/openstack/heat/commit?h=2b69e0e245ff4cf81d9f41e5e05947f6aef0004f to force immediate translation of error messages before storing to the database used str() instead of six.text_type() to convert them, with the result that it fails when the translated message includes non-ASCII characters.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/466884

Changed in heat:
assignee: nobody → Zane Bitter (zaneb)
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/466884
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=007d4cbfdd4cfa3764b2b9789f129f2aae654a66
Submitter: Jenkins
Branch: master

commit 007d4cbfdd4cfa3764b2b9789f129f2aae654a66
Author: Zane Bitter <email address hidden>
Date: Mon May 22 15:53:39 2017 -0400

    Use six.text_type() instead of str() to serialise status

    Change-Id: Icdcacef27595728b94df7aaf9819f234ad6f2dfa
    Closes-Bug: #1692693

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/469510

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/ocata)

Reviewed: https://review.openstack.org/469510
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=45b9769212a7cdf61e44158395f3b97353feb7c0
Submitter: Jenkins
Branch: stable/ocata

commit 45b9769212a7cdf61e44158395f3b97353feb7c0
Author: Zane Bitter <email address hidden>
Date: Mon May 22 15:53:39 2017 -0400

    Use six.text_type() instead of str() to serialise status

    Change-Id: Icdcacef27595728b94df7aaf9819f234ad6f2dfa
    Closes-Bug: #1692693
    (cherry picked from commit 007d4cbfdd4cfa3764b2b9789f129f2aae654a66)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 9.0.0.0b2

This issue was fixed in the openstack/heat 9.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 8.0.2

This issue was fixed in the openstack/heat 8.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.