environment's parameter_defaults not applied some parameter types

[Yanis Guenane]

Context:

 * Current tripleo-heat-templates master + https://review.openstack.org/#/c/232051/
 * Current python-tripleoclient master

Goals:

  Allow a user to pass more than one ntp server url in the command line.
  Possible syntax :

    * --ntp-server 0.test.com,1.test.com
    * --ntp-server 0.test.com --ntp-server 1.test.com (by adding action='append' to the param - https://review.openstack.org/#/c/232075/)

 In order to support such use cases NtpServer has been switched from string to comma_delimited_list[1][2]

# Case 1

If I use directly --ntp-sever, for some reason the value is not passed to the Heat templates. NtpServer end up being empty

## Result 1

[stack@instack ~]$ openstack overcloud deploy --templates --ntp-server 0.test.com,1.test.com
[...]
[stack@instack ~]$ heat stack-show overcloud | grep Ntp
| | "NtpServer": "",

# Case 2

If I use an Heat environment file, the NtpServer is filled acordingly.

## Result 2

[stack@instack ~]$ cat env.yaml
parameters:
  NtpServer: 0.test.com,1.test.com
[stack@instack ~]$ openstack overcloud deploy --templates -e env.yaml
[...]
heat stack-show overcloud | grep Ntp
| | "NtpServer": "0.test.com,1.test.com",

[1] https://review.openstack.org/#/c/232051/
[2] http://docs.openstack.org/developer/heat/template_guide/hot_spec.html#parameters-section

Expected Results:

  Whether using tripleoclient --ntp-server or directly the Heat environment, the value should be passed either way.

[Jiří Stránský (jistr)]

It is reproducible even with heatclient (with no tripleoclient involved). The parameter_defaults are passed from heatclient correctly though. This is a bug in Heat, it doesn't process environment's parameter_defaults correctly for any value of type comma_delimited_list. I hope i'll have a fix for this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/234055

[Steven Hardy (shardy)]

As reported by dprince, this only affects the top-level stack:

https://bugs.launchpad.net/heat/+bug/1460063

I failed to reproduce that because I tried with "number" not "json" or "comma_delimited_list".

[Steven Hardy (shardy)]

I wrote some tests and this does affect both comma_delimited_list and json parameter types

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/234055
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3827c61b25fa86c1f9882be15caf27d2efa6c4fe
Submitter: Jenkins
Branch: master

commit 3827c61b25fa86c1f9882be15caf27d2efa6c4fe
Author: Jiri Stransky <email address hidden>
Date: Tue Oct 13 10:57:06 2015 +0200

    Fix parameter_defaults for comma_delimited_list and json

    When environment of a stack contained a parameter_defaults section with
    a value for a parameter of type comma_delimited_list or json, that default
    didn't get applied unless in a nested stack.

    The issue was that CommaDelimitedListParam contains a variable to cache
    its value, and that cache was only created upon creation of a
    CommaDelimitedListParam object, but it wasn't updated on `set_default`
    method call. The cache now updates on `set_default` too.

    Co-Authored-By: Steven Hardy <email address hidden>
    Change-Id: I85b13a79dbc97a77e20c0d5df8eaf05b3000815e
    Closes-Bug: #1504137

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/235349

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235349
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=c7795a7be9125f2d42075b127f5696c806380aef
Submitter: Jenkins
Branch: stable/liberty

commit c7795a7be9125f2d42075b127f5696c806380aef
Author: Jiri Stransky <email address hidden>
Date: Tue Oct 13 10:57:06 2015 +0200

    Fix parameter_defaults for comma_delimited_list and json

    When environment of a stack contained a parameter_defaults section with
    a value for a parameter of type comma_delimited_list or json, that default
    didn't get applied unless in a nested stack.

    The issue was that CommaDelimitedListParam contains a variable to cache
    its value, and that cache was only created upon creation of a
    CommaDelimitedListParam object, but it wasn't updated on `set_default`
    method call. The cache now updates on `set_default` too.

    Co-Authored-By: Steven Hardy <email address hidden>
    Change-Id: I85b13a79dbc97a77e20c0d5df8eaf05b3000815e
    Closes-Bug: #1504137
    (cherry picked from commit 3827c61b25fa86c1f9882be15caf27d2efa6c4fe)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/244691

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/244691
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=f47cf4eb4544c75947a8ad635ab4cc6065b1483e
Submitter: Jenkins
Branch: stable/kilo

commit f47cf4eb4544c75947a8ad635ab4cc6065b1483e
Author: Jiri Stransky <email address hidden>
Date: Tue Oct 13 10:57:06 2015 +0200

    Fix parameter_defaults for comma_delimited_list and json

    When environment of a stack contained a parameter_defaults section with
    a value for a parameter of type comma_delimited_list or json, that default
    didn't get applied unless in a nested stack.

    The issue was that CommaDelimitedListParam contains a variable to cache
    its value, and that cache was only created upon creation of a
    CommaDelimitedListParam object, but it wasn't updated on `set_default`
    method call. The cache now updates on `set_default` too.

    Conflicts:
     heat/engine/parameters.py

    Co-Authored-By: Steven Hardy <email address hidden>
    Change-Id: I85b13a79dbc97a77e20c0d5df8eaf05b3000815e
    Closes-Bug: #1504137
    (cherry picked from commit 3827c61b25fa86c1f9882be15caf27d2efa6c4fe)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/heat 6.0.0.0b1 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/heat 5.0.1 release.