2 unit tests failing with python 3.6

Bug #1750252 reported by Thomas Goirand
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Rabi Mishra

Bug Description

Failed 2 tests - output below:
==============================

heat.tests.test_convg_stack.StackConvergenceCreateUpdateDeleteTest.test_conv_empty_template_stack_update_delete
---------------------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/usr/lib/python3/dist-packages/mock/mock.py", line 1305, in patched'
    b' return func(*args, **keywargs)'
    b' File "/home/zigo/sources/openstack/queens/services/heat/build-area/heat-10.0.0~rc1/heat/tests/test_convg_stack.py", line 363, in test_conv_empty_template_stack_update_delete'
    b' self.assertEqual(expected_calls, mock_cr.mock_calls)'
    b' File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 411, in assertEqual'
    b' self.assertThat(observed, matcher, message)'
    b' File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 498, in assertThat'
    b' raise mismatch_error'
    b'testtools.matchers._impl.MismatchError: !=:'
    b"reference = [call.worker_client.WorkerClient.check_resource(<heat.common.context.RequestContext object at 0x7f432ee9a160>, 5, '4742dc19-089a-414b-a616-a0820d81bada', {'input_data': {}}, True, None, False),"
    b" call.worker_client.WorkerClient.check_resource(<heat.common.context.RequestContext object at 0x7f432ee9a160>, 4, '4742dc19-089a-414b-a616-a0820d81bada', {'input_data': {}}, True, None, False),"
    b" call.worker_client.WorkerClient.check_resource(<heat.common.context.RequestContext object at 0x7f432ee9a160>, 1, 'eaed0d19-ec52-4124-aa2f-78580f4511ac', {'input_data': {}}, False, None, False),"
    b" call.worker_client.WorkerClient.check_resource(<heat.common.context.RequestContext object at 0x7f432ee9a160>, 2, 'eaed0d19-ec52-4124-aa2f-78580f4511ac', {'input_data': {}}, False, None, False)]"
    b"actual = [call(<heat.common.context.RequestContext object at 0x7f432ee9a160>, 5, '4742dc19-089a-414b-a616-a0820d81bada', {'input_data': {}}, True, None, False),"
    b" call(<heat.common.context.RequestContext object at 0x7f432ee9a160>, 4, '4742dc19-089a-414b-a616-a0820d81bada', {'input_data': {}}, True, None, False),"
    b" call(<heat.common.context.RequestContext object at 0x7f432ee9a160>, 2, 'eaed0d19-ec52-4124-aa2f-78580f4511ac', {'input_data': {}}, False, None, False),"
    b" call(<heat.common.context.RequestContext object at 0x7f432ee9a160>, 1, 'eaed0d19-ec52-4124-aa2f-78580f4511ac', {'input_data': {}}, False, None, False)]"
    b''
    b''

Captured pythonlogging:
~~~~~~~~~~~~~~~~~~~~~~~
    b' INFO [heat.engine.stack] convergence_dependencies: {ConvergenceNode(rsrc_id=5, is_update=True): {}, ConvergenceNode(rsrc_id=3, is_update=True): {ConvergenceNode(rsrc_id=5, is_update=True), ConvergenceNode(rsrc_id=4, is_update=T
    b' INFO [heat.engine.stack] Triggering resource 5 for update'
    b' INFO [heat.engine.stack] Triggering resource 4 for update'
    b' INFO [heat.engine.stack] convergence_dependencies: {ConvergenceNode(rsrc_id=1, is_update=False): {}, ConvergenceNode(rsrc_id=3, is_update=False): {ConvergenceNode(rsrc_id=2, is_update=False), ConvergenceNode(rsrc_id=1, is_updat
    b' INFO [heat.engine.stack] Triggering resource 2 for cleanup'
    b' INFO [heat.engine.stack] Triggering resource 1 for cleanup'
    b''

heat.tests.test_convg_stack.StackConvergenceCreateUpdateDeleteTest.test_conv_string_five_instance_stack_create
--------------------------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    b'Traceback (most recent call last):'
    b' File "/usr/lib/python3/dist-packages/mock/mock.py", line 1305, in patched'
    b' return func(*args, **keywargs)'
    b' File "/home/zigo/sources/openstack/queens/services/heat/build-area/heat-10.0.0~rc1/heat/tests/test_convg_stack.py", line 132, in test_conv_string_five_instance_stack_create'
    b' self.assertEqual(expected_calls, mock_cr.mock_calls)'
    b' File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 411, in assertEqual'
    b' self.assertThat(observed, matcher, message)'
    b' File "/usr/lib/python3/dist-packages/testtools/testcase.py", line 498, in assertThat'
    b' raise mismatch_error'
    b'testtools.matchers._impl.MismatchError: !=:'
    b"reference = [call.worker_client.WorkerClient.check_resource(<heat.common.context.RequestContext object at 0x7fe768596e80>, 4, '113f6755-4865-4037-a9c5-7dc18393426d', {'input_data': {}}, True, None, False),"
    b" call.worker_client.WorkerClient.check_resource(<heat.common.context.RequestContext object at 0x7fe768596e80>, 5, '113f6755-4865-4037-a9c5-7dc18393426d', {'input_data': {}}, True, None, False)]"
    b"actual = [call(<heat.common.context.RequestContext object at 0x7fe768596e80>, 5, '113f6755-4865-4037-a9c5-7dc18393426d', {'input_data': {}}, True, None, False),"
    b" call(<heat.common.context.RequestContext object at 0x7fe768596e80>, 4, '113f6755-4865-4037-a9c5-7dc18393426d', {'input_data': {}}, True, None, False)]"
    b''
    b''

Captured pythonlogging:
~~~~~~~~~~~~~~~~~~~~~~~
    b' INFO [heat.engine.stack] convergence_dependencies: {ConvergenceNode(rsrc_id=4, is_update=True): {}, ConvergenceNode(rsrc_id=3, is_update=True): {ConvergenceNode(rsrc_id=5, is_update=True), ConvergenceNode(rsrc_id=4, is_update=T
    b' INFO [heat.engine.stack] Triggering resource 5 for update'
    b' INFO [heat.engine.stack] Triggering resource 4 for update'
    b''

Revision history for this message
Thomas Goirand (thomas-goirand) wrote :

Note: this happened when building heat 10.0.0~rc1 in Debian sid, and these unit tests passed without issue using Python 2.7. It'd be nice to have them fixed because the package (like all other packages in Debian) is switching to Python 3.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/546137

Changed in heat:
assignee: nobody → Rabi Mishra (rabi)
status: New → In Progress
Zane Bitter (zaneb)
Changed in heat:
milestone: none → queens-rc2
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/546137
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=e09b879a289f10bf50353a7c4dd64df5566cb9cd
Submitter: Zuul
Branch: master

commit e09b879a289f10bf50353a7c4dd64df5566cb9cd
Author: rabi <email address hidden>
Date: Tue Feb 20 15:48:10 2018 +0530

    Fix convergence unit tests for py36

    Change-Id: I90d68a9b35a1f23195b7153eba83f2bcd0ae6ef6
    Closes-Bug: #1750252

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/546541

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/queens)

Reviewed: https://review.openstack.org/546541
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=590f3a0d5b3b4dcb74ec3a3d9050b0339ec366af
Submitter: Zuul
Branch: stable/queens

commit 590f3a0d5b3b4dcb74ec3a3d9050b0339ec366af
Author: rabi <email address hidden>
Date: Tue Feb 20 15:48:10 2018 +0530

    Fix convergence unit tests for py36

    Change-Id: I90d68a9b35a1f23195b7153eba83f2bcd0ae6ef6
    Closes-Bug: #1750252
    (cherry picked from commit e09b879a289f10bf50353a7c4dd64df5566cb9cd)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 10.0.0.0rc2

This issue was fixed in the openstack/heat 10.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 11.0.0.0b1

This issue was fixed in the openstack/heat 11.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.