Intermittent failure in Monasca client unit test

Bug #1750024 reported by Zane Bitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Zane Bitter

Bug Description

The test added in https://review.openstack.org/#/c/497931/ fails intermittently, because it does not keep a local reference to the context before passing it to the ClientPlugin, which stores only a weak reference.

4 failures in the past week:

http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22AssertionError%3A%20Need%20a%20reference%20to%20the%20context%5C%22

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/545429

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/545429
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6b99a54cbe02a1859d97475ea6681df2b266b6e1
Submitter: Zuul
Branch: master

commit 6b99a54cbe02a1859d97475ea6681df2b266b6e1
Author: Zane Bitter <email address hidden>
Date: Fri Feb 16 13:19:22 2018 -0500

    Unit tests: Fix broken Monasca client test

    The context is held by a weak reference in the ClientPlugin, so don't let
    it go out of scope in the caller.

    This test was added by 36e53d3c2b973c45a4dc7af7af39b0110437de48.

    Change-Id: I6a313970f1c0604e94d008eb12aeaa94da1d25c4
    Closes-Bug: #1750024

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/545605

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/queens)

Reviewed: https://review.openstack.org/545605
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=40a32f81c2c231c18d8ed9877be601db87fd4f37
Submitter: Zuul
Branch: stable/queens

commit 40a32f81c2c231c18d8ed9877be601db87fd4f37
Author: Zane Bitter <email address hidden>
Date: Fri Feb 16 13:19:22 2018 -0500

    Unit tests: Fix broken Monasca client test

    The context is held by a weak reference in the ClientPlugin, so don't let
    it go out of scope in the caller.

    This test was added by 36e53d3c2b973c45a4dc7af7af39b0110437de48.

    Change-Id: I6a313970f1c0604e94d008eb12aeaa94da1d25c4
    Closes-Bug: #1750024
    (cherry picked from commit 6b99a54cbe02a1859d97475ea6681df2b266b6e1)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 10.0.0.0rc2

This issue was fixed in the openstack/heat 10.0.0.0rc2 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 11.0.0.0b1

This issue was fixed in the openstack/heat 11.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.