contrib unit tests are no longer run

[Zane Bitter]

In .testr.conf, we had a line to add tests from contrib directories by doing a separate discovery on them:

  if [ "$START_AT" = "." ]; then for plugin in $START_AT/contrib/*; do ${PYTHON} -m subunit.run discover -s $plugin $LISTOPT $IDOPTION; done; fi

In https://review.openstack.org/#/c/528172/ we switched to stestr, which does not appear to offer similar flexibility. Since then, contrib directories are going silently untested.

[Rabi Mishra (rabi)]

I think they are not running since https://review.openstack.org/#/c/348569/7/, where we've added the below.

OS_TEST_PATH=heat/tests
TESTR_START_DIR=heat/tests.

Many of the tests are broken now, including the heat_docker ones as they not tested/maintained since 2/3 cycles.

Ran 153 (+152) tests in 13.537s (+13.175s)
FAILED (id=208, failures=47 (+47))
error: testr failed (1)

IMHO, we should get rid of everything in the contrib along with the docker resource (Prefer users to use the docker-cmd hook instead). Otherwise, we'll have to find a way to dynamically load and run these tests.

[Zane Bitter (zaneb)]

I already submitted a patch to remove the Rackspace ones: https://review.openstack.org/#/c/541475/

It appears there are still people using the Docker one: https://review.openstack.org/#/c/533209/
OTOH it is really only a toy anyway, so maybe we could get rid of it.