Attributes not stored for ResourceGroup after rolling update

[Zane Bitter]

When referencing attributes of ResourceGroups, we should generate outputs in the nested template that reference the resource attributes. However there are two separate template generation paths, for rolling updates and non-rolling operation. Only the latter path includes the outputs, so when rolling updates are enabled there are no outputs generated in the nested template.

This would cause the nested stack to not think these attributes are referenced, and therefore not store them.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/531926

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/531926
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=7a046e6ffd8daaa21202eeb691d12f2dbf9abfc1
Submitter: Zuul
Branch: master

commit 7a046e6ffd8daaa21202eeb691d12f2dbf9abfc1
Author: Zane Bitter <email address hidden>
Date: Mon Jan 8 17:23:12 2018 -0500

    Include outputs in rolling update of ResourceGroup

    The template generated by ResourceGroup should include outputs that
    reference any needed resource attributes. However, previously it only did
    so when rolling updates were not enabled by an update_policy.

    Change-Id: Ice7a92fe8d2b14e2470d9089a8e191c8385994f1
    Closes-Bug: #1741981
    Partial-Bug: #1731349
    Related-Bug: #1660831

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/541763

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 10.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/541763
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=1cb985536c6b208b2a9616f6ac9083570bb786d8
Submitter: Zuul
Branch: stable/pike

commit 1cb985536c6b208b2a9616f6ac9083570bb786d8
Author: Zane Bitter <email address hidden>
Date: Mon Jan 8 17:23:12 2018 -0500

    Include outputs in rolling update of ResourceGroup

    The template generated by ResourceGroup should include outputs that
    reference any needed resource attributes. However, previously it only did
    so when rolling updates were not enabled by an update_policy.

    The tests are trivially different than the patch on master, only because
    ce120bfda848e55ba06b606681e7c1b8ae3de923 is not present in Pike.

    Change-Id: Ice7a92fe8d2b14e2470d9089a8e191c8385994f1
    Closes-Bug: #1741981
    Partial-Bug: #1731349
    Related-Bug: #1660831
    (cherry picked from commit 7a046e6ffd8daaa21202eeb691d12f2dbf9abfc1)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 9.0.4 release.