OpenStack Heat

Functions in e.g. metadata not validated

Bug #1732798 reported by Zane Bitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Zane Bitter
OpenStack Heat queens-3

Bug Description

Since https://review.openstack.org/#/c/386852/ merged (in Ocata), not all intrinsic functions in resource definitions get validated during initial template validation. For example, functions in the metadata section are not validated.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/520831

Changed in heat:
status: Triaged → In Progress
Zane Bitter (zaneb)
Changed in heat:
milestone: none → queens-2
Rico Lin (rico-lin)
Changed in heat:
milestone: queens-2 → queens-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/520831
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=316b80e1d51cafb3beeab408664775c825febe17
Submitter: Zuul
Branch: master

commit 316b80e1d51cafb3beeab408664775c825febe17
Author: Zane Bitter <email address hidden>
Date: Thu Nov 16 18:17:23 2017 -0500

    Ensure the whole ResourceDefinition is validated

    We used to validate intrinsic functions in the ResourceDefinition by just
    passing it to function.validate(). That worked when it also acted as a
    CloudFormation template snippet but, since that behaviour was removed by
    2c6fc7bcd6b280a85488b0f32f8db7c7835f8b5c, that call now does nothing. This
    replaces it with a validate() method on the ResourceDefinition itself.

    This also improves path reporting for validation errors in deletion or
    update policies.

    Change-Id: I58c788002136ddf9bded309366e2072823b3ac77
    Closes-Bug: #1732798

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 10.0.0.0b3

This issue was fixed in the openstack/heat 10.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.