Template Guide: required status of nested properties not documented

Bug #1694748 reported by Zane Bitter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Kaz Shinohara

Bug Description

In the Resource reference of the Template Guide:

https://docs.openstack.org/heat/latest/template_guide/openstack.html

we group top-level properties of resources into Required and Optional sections. However, where properties are themselves Maps that have subproperties, we don't separate the subproperties into Required and Optional so the user has no way of telling without looking at the code.

e.g. under
https://docs.openstack.org/heat/latest/template_guide/openstack.html#OS::Neutron::Port-prop-allowed_address_pairs the subproperty "ip_address" is required whereas "mac_address" is not,[1] but you'd never know that from the docs.

[1] http://git.openstack.org/cgit/openstack/heat/tree/heat/engine/resources/openstack/neutron/port.py?h=stable%2Focata#n232

Zane Bitter (zaneb)
tags: added: documentation
Kaz Shinohara (kazsh)
Changed in heat:
assignee: nobody → Kazunori Shinohara (ksnhr)
Revision history for this message
Kaz Shinohara (kazsh) wrote :

Let me work for this, suppose we can make it by upgrading /doc/source/ext/resource.py

Rico Lin (rico-lin)
Changed in heat:
milestone: none → pike-3
Rico Lin (rico-lin)
Changed in heat:
milestone: pike-3 → pike-rc1
Kaz Shinohara (kazsh)
Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/490805

Rico Lin (rico-lin)
description: updated
Rabi Mishra (rabi)
Changed in heat:
milestone: pike-rc1 → pike-rc2
Rico Lin (rico-lin)
Changed in heat:
milestone: pike-rc2 → queens-1
Rico Lin (rico-lin)
Changed in heat:
milestone: queens-1 → queens-2
Rico Lin (rico-lin)
Changed in heat:
milestone: queens-2 → queens-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/490805
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=50088c572e5abe3001db47e35875a3dfe47e8381
Submitter: Zuul
Branch: master

commit 50088c572e5abe3001db47e35875a3dfe47e8381
Author: kaz_shinohara <email address hidden>
Date: Fri Aug 4 17:22:43 2017 +0900

    Updated the template guide.

    The current template guide does not show required/optional flag
    for subproperties, it means that users need to look at the source
    code to clarify if the subproperties is required or not.
    Updated a sphinx extension doc/ext/resource.py to display
    required/optional flag for subproperties.

    Change-Id: Ie9e23d633d749aa7ad087330520cd3b83294794a
    Closes-Bug: #1694748

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 10.0.0.0b3

This issue was fixed in the openstack/heat 10.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.