Need to stop using image/floating_ip passthroughs in novaclient

[Zane Bitter]

The gate is broken due to the release of python-novaclient 8.0.0. That release removed the passthroughs to glance and neutron (respectively) for the image and floating_ip APIs, which have apparently been deprecated since Newton (although clearly we didn't get the memo).

We need to stop using novaclient to access these APIs, and replace it with glanceclient and neutronclient.

Sample logs:
http://logs.openstack.org/04/461504/2/check/gate-heat-python27-ubuntu-xenial/3ad487a/
http://logs.openstack.org/04/461504/2/check/gate-heat-dsvm-functional-orig-mysql-lbaasv2-ubuntu-xenial/313a1b4/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/464957

[Rabi Mishra (rabi)]

Looks like nova-network support is gone from the python-novaclient along with the passthroughs. Not sure what would be the impact of this for sahara/trove and manilla that support nova-network. AFAICT, this is a major change for us. I've pushed a WIP patch to see if it atleast fixes the gate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/464957
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=e8e0a2483a8cd0edbd0ec77d92d638974c72f290
Submitter: Jenkins
Branch: master

commit e8e0a2483a8cd0edbd0ec77d92d638974c72f290
Author: rabi <email address hidden>
Date: Tue May 16 09:29:07 2017 +0530

    Fix python-novaclient 8.0.0 related issues

    New python-novaclient release has removed support for
    network/image/floating_ip apis. This also means
    nova-network support would also cease to exist after
    this change.

    Change-Id: Icbcf279c10720f99a0aed1a3aaaf3945c5442a8a
    Closes-Bug: #1690936

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/465527

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/465527
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=882c4dc1063f22fdc73b162402900cfb8932fb08
Submitter: Jenkins
Branch: master

commit 882c4dc1063f22fdc73b162402900cfb8932fb08
Author: rabi <email address hidden>
Date: Tue May 16 09:29:07 2017 +0530

    Bring back EIP unit tests

    Icbcf279c10720f99a0aed1a3aaaf3945c5442a8a removed the eip unit
    tests. This patch restores them.

    Change-Id: I14b612cc39021ea8f84aeb2d0577db5eac47728c
    Related-Bug: #1690936

[Amrith Kumar (amrith)]

It is unverified in my mind that this impacts Trove but someone entered a new bug (https://bugs.launchpad.net/trove/+bug/1691365) which was literally a copy-pasta of this one for Trove.

[Zane Bitter (zaneb)]

The logs they linked to - http://logs.openstack.org/63/416163/1/check/gate-trove-python27-ubuntu-xenial/7d70d95/ - make it clear that the trove tests have the same issue.

[Trevor McCasland (twm2016)]

I can confirm trove is using the novaclient for floating ips in at least their taskmanager/models.py so if its true we can no longer use floating_ips through the nova client then this affects trove.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/466187

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/467447

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/467447
Committed: https://git.openstack.org/cgit/openstack/trove/commit/?id=3ed3ea94bb03563a349cde686a8e38f68a7b5a53
Submitter: Jenkins
Branch: master

commit 3ed3ea94bb03563a349cde686a8e38f68a7b5a53
Author: Amrith Kumar <email address hidden>
Date: Tue May 23 22:22:26 2017 -0400

    fix issue with Nova passthrough deprecation

    Nova Networking was deprecated in Newton and some of the API calls
    that were part of NN were still in use by Trove. With the arrival of
    python-novaclient 8.0.0, this caused a failure.

    Nova also deprecated the image pass through capability. The management
    API uses some of that to test whether an image id is valid or
    not. This change fixes the management API, and the attendant scenario
    tests.

    Depends-On: I142f97d691fa55e9824714c9c224f998ad72337e

    Change-Id: I2f2a12207581a94fb8561a6d65a3a79b4a29b063
    Closes-Bug: #1690936

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 9.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/trove 8.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466187
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=beb7a0495083802b3291a3f44f0b6e106413f603
Submitter: Jenkins
Branch: master

commit beb7a0495083802b3291a3f44f0b6e106413f603
Author: rabi <email address hidden>
Date: Thu May 18 12:05:18 2017 +0530

    Fix nova floatingip resources

    Change recently deprecated nova fip resources to make neutron api
    calls.

    Change-Id: I3b52ac60af7b65b04f96314b0971dbf1c161dcca
    Related-Bug: #1690936