unclear validation error mesage for nested stacks

[Rabi Mishra]

Error message has 'Failed to validate' twice and there is no way to locate the resource/template.

[stack@f25-devstack exmaples]$ cat test_rsg.yaml
heat_template_version: ocata
resources:
  rsg:
    type: OS::Heat::ResourceGroup
    properties:
      count: 1
      resource_def:
        type: server.yaml
        properties:
          image: cirros-0.3.5-x86_64-disk
          flavor: m1.nano
[stack@f25-devstack exmaples]$ cat server.yaml
heat_template_version: ocata
parameters:
  image:
    type: string
    default: cirros-0.3.5-x86_64-disk
  flavor:
    type: string
    default: m1.nano
resources:
  server:
    type: OS::Nova::Server
    properties:
      image: {get_param: image}
      #flavor: {get_param: flavor}

[stack@f25-devstack exmaples]$ openstack stack create test_stack -t test_rsg.yaml
ERROR: Failed to validate: Failed to validate: resources[0]: Property flavor not assigned

[Thomas Herve (therve)]

That's horrible, but not new. It'd be great to fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/466802

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/466802
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=fe74658ff06b76d83b5b1595fa4529d373d78cce
Submitter: Jenkins
Branch: master

commit fe74658ff06b76d83b5b1595fa4529d373d78cce
Author: rabi <email address hidden>
Date: Mon May 22 15:06:57 2017 +0530

    Improve StackValidationFailed exception

    We use StackValidationFailed in many different scenarios and
    the the message is at times extremely unhelpful, specifically
    when the validation error is deep in a nested stack.

    Change-Id: I0183bdf81442e62325a427b4eec5c4cd9b7cb91f
    Closes-Bug: #1686360

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 9.0.0.0b3 development milestone.