There is no need to do "None" value check

[Jeffrey Guan]

There is no need to do "None" value check
for self.VOLUME_TYPE and self.SERVER_TYPE
in handle_create() and validate() in
heat/engine/resources/openstack/magnum/cluster_template.py

From the defination of self.VOLUME_TYPE and self.SERVER_TYPE,
there are already constraints for their allowed values. So,
the extra "None" value check is not needed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/449448

[Rabi Mishra (rabi)]

I think VOLUME_TYPE is optional porperty. If the property is not specified in the template it would be None. SERVER_TYPE is checked along with other optional properties for None[1]. So not sure why this is a bug???

[1] https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/magnum/cluster_template.py#L247

[OpenStack Infra (hudson-openstack)]

Change abandoned by JeffreyGuan ([e-mail]) on branch: master
Review: https://review.openstack.org/449448
Reason: This is not a bug. self.VOLUME_TYPE and self.SERVER_TYPE is not always "required" for this resource. So the check for None is necessary

[Jeffrey Guan (double12gzh)]

Thank you for your reply. It's my fault.

I only noticed there is a constrain for their value but take for granted these properties is "required".