correct wait condition validation

[huangtianhua]

1. create a stack with wait condition resource:
********************************
heat_template_version: newton
resources:
  wch:
    type: OS::Heat::WaitConditionHandle

  wc:
    type: OS::Heat::WaitCondition
    properties:
      handle: whc
      timeout: 120
outputs:
  wch_signal:
    value: {get_attr: [wch, signal]}
  wc_data:
    value: {get_attr: [wc, data]}
********************************
2. due the typo 'whc' in property 'handle' of wc, the stack create failed, the reason is: Resource CREATE failed: AttributeError: resources.wc: 'NoneType' object has no attribute 'name' , and the output of wc_data is:
{
| | "output_value": null, |
| | "output_error": "'NoneType' object has no attribute 'metadata_get'", |
| | "output_key": "wc_data", |
| | "description": "No description given" |
| | },

3. something wrong happened when validating.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/436782

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/436782
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=a4e85e21905732c8179f263929b751c645f10f41
Submitter: Jenkins
Branch: master

commit a4e85e21905732c8179f263929b751c645f10f41
Author: huangtianhua <email address hidden>
Date: Wed Feb 22 12:14:01 2017 +0800

    Correct validation of wait conditon

    This changes:
    1. if the referenced wait condition is invalid,
       return '' when resolve attribute.
    2. if the referenced wait condition is invalid,
       raise error with correct message.

    Closes-Bug: #1666747

    Change-Id: I69248c2bd80246ea6d08c1f140885e4b461353a0

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 9.0.0.0b3 development milestone.