Software Deployment with DELETE deploy action fails with convergence

Bug #1635610 reported by Rabi Mishra
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Rabi Mishra
Newton
Fix Committed
Undecided
Rabi Mishra

Bug Description

Software deployment with DELETE deploy action fails with the below error and the deployment gets stuck in DELETE_IN_PROGRESS.

"Stack or resource not found: a18a7fe3-70c3-4dc6-9f2f-a89022bce429 delete_sd"

I think we update with an empty template when deleting a stack in convergcence and the resource does not exist, when looking for it with 'stack[resource_name]'.

Rabi Mishra (rabi)
summary: - Software Deployment with delete action fails with convergence
+ Software Deployment with DELETE deploy action fails with convergence
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/389677

Changed in heat:
status: New → In Progress
Rabi Mishra (rabi)
Changed in heat:
importance: Undecided → High
milestone: none → ocata-1
Rabi Mishra (rabi)
description: updated
Zane Bitter (zaneb)
tags: added: newton-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/389677
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=26aa33eb6629c707025f2dc8c92995d555409bea
Submitter: Jenkins
Branch: master

commit 26aa33eb6629c707025f2dc8c92995d555409bea
Author: rabi <email address hidden>
Date: Fri Oct 21 16:51:10 2016 +0530

    Fix resource_signal with convergence

    When doing a stack delete, we update it with an
    empty template. Therefore checking for the resource
    in the template would fail in resource_signal.

    Change-Id: Id8c2226e78ed74138ce9065c4435aa5778726656
    Closes-Bug: #1635610

Changed in heat:
status: In Progress → Fix Released
Rabi Mishra (rabi)
tags: removed: newton-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/newton)

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/394811

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/newton)

Reviewed: https://review.openstack.org/394811
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=827b55bce9dccda61130f5ea419185814f68b751
Submitter: Jenkins
Branch: stable/newton

commit 827b55bce9dccda61130f5ea419185814f68b751
Author: rabi <email address hidden>
Date: Fri Oct 21 16:51:10 2016 +0530

    Fix resource_signal with convergence

    When doing a stack delete, we update it with an
    empty template. Therefore checking for the resource
    in the template would fail in resource_signal.

    Change-Id: Id8c2226e78ed74138ce9065c4435aa5778726656
    Closes-Bug: #1635610
    (cherry picked from commit 26aa33eb6629c707025f2dc8c92995d555409bea)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 8.0.0.0b1

This issue was fixed in the openstack/heat 8.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 7.0.1

This issue was fixed in the openstack/heat 7.0.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to heat (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/486756

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to heat (master)

Reviewed: https://review.openstack.org/486756
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d45de801b2b15570c47ab6d7a14a1236eb7970df
Submitter: Jenkins
Branch: master

commit d45de801b2b15570c47ab6d7a14a1236eb7970df
Author: Zane Bitter <email address hidden>
Date: Mon Jul 24 17:21:28 2017 -0400

    Don't get resource twice in resource_signal()

    For no reason at all, we were calling Stack.resource_get() twice in
    handle_signal(). In the worst case, this function does a database query
    that loads every resource.

    Change-Id: I9e3f1e77146c71ae35a0896f915f6f9c9fac3fd3
    Related-Bug: #1635610

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.