Heat engine doesn't detect lbaas listener failures

[Jiahao liang]

Please refer to the mail-list for comments from other developers, https://openstack.nimeyo.com/97427/openstack-neutron-octavia-doesnt-detect-listener-failures

I am trying to use heat to launch lb resources with Octavia as backend. The
template I used is from
https://github.com/openstack/heat-templates/blob/master/hot/lbaasv2/lb_group.yaml
.

Following are a few observations:

1. Even though Listener was created with ERROR status, heat will still go
ahead and mark it Creation Complete. As in the heat code, it only check
whether root Loadbalancer status is change from PENDING_UPDATE to ACTIVE.
And Loadbalancer status will be changed to ACTIVE anyway no matter
Listener's status.

2. As heat engine wouldn't know the Listener's creation failure, it will
continue to create Pool\Member\Heatthmonitor on top of an Listener which
actually doesn't exist. It causes a few undefined behaviors. As a result,
those LBaaS resources in ERROR state are unable to be cleaned up
with either normal neutron or heat api.

3. The bug is introduce from here, https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/neutron/lbaas/listener.py#L188. It only checks the provisioning status of the root loadbalancer. However the listener itself has its own provisioning status which may go into ERROR.

4. The same scenario applies for not only listener but also pool, member, healthmonitor, etc., basically every resources except loadbalancer from lbaas.

[Rabi Mishra (rabi)]

As mentioned in the mail thread you mentioned and confirmed by the lbaas team, this would probably need changes in lbaas first.

- lbaas api should expose provisioning_status for all top level objects (ex. listener)
api
- The suggested status api('show-load-balancer-status-tree'), which could probably be used in the meantime has bugs. Therefore we should probably wait till this is implemented properly in lbaas.

[Michael Johnson (johnsom)]

The work in Octavia is complete for adding provisioning status to all of the objects. We just need to make sure that is available via the APISs and clients.
Provisioning status work was done here: https://review.openstack.org/#/c/372791/

[Zhixin Li (lizhixin)]

Doesn't it need to add an affected project for neutron-lbaas? We need to expose provisioning_status for all top level objects of lbaas.

[Michael Johnson (johnsom)]

The neutron project with lbaas tag was for neutron-lbaas, but now that we have merged the projects, I am removing neutron as it is all under octavia project now.

[Rabi Mishra (rabi)]

Please use the new octavia resources in heat and report back if you still see the issues.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Adam Harwell (<email address hidden>) on branch: master
Review: https://review.opendev.org/405780
Reason: This review is > 4 weeks without comment and currently blocked by a core reviewer with a -2. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and contacting the reviewer with the -2 on this review to ensure you address their concerns.

[Gregory Thiemonge (gthiemonge)]

Abandoned after re-enabling the Octavia launchpad.