OS::Neutron::FloatingIP has too many dependencies

Bug #1626634 reported by Zane Bitter on 2016-09-22
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
In Progress
Medium
Zane Bitter

Bug Description

Now that bug 1626619 is fixed, we're once again depending on *all* RouterInterfaces that are defined in the template, instead of just the ones on Networks that we care about.

This is very similar to the issue with RouterGateway and ExtraRoutes (bug 1626630), which should be fixed first. Once it is, we can try to apply the same solution here.

The major difference with FloatingIP is that it needs to going up two levels in the graph instead of just one (FloatingIP->Port->Network and RouterInterface->Subnet->Network) to get to the shared root that we want to compare.

This would also allow us to get rid of the expensive API call mentioned in bug 1626619, which ideally has no place in the dependency calculations, without compromising the fix for bug 1428434.

See further discussion in https://review.openstack.org/#/c/289371/ for context.

Zane Bitter (zaneb) on 2016-09-22
Changed in heat:
status: New → Triaged
importance: Undecided → Medium
milestone: none → ocata-1

Fix proposed to branch: master
Review: https://review.openstack.org/381219

Changed in heat:
assignee: nobody → Oleksii Chuprykov (ochuprykov)
status: Triaged → In Progress

Reviewed: https://review.openstack.org/381925
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=de319d211ea1e064944011bd8f6d265a7fd7736e
Submitter: Jenkins
Branch: master

commit de319d211ea1e064944011bd8f6d265a7fd7736e
Author: Oleksii Chuprykov <email address hidden>
Date: Tue Oct 4 18:12:33 2016 +0300

    Add implicit deps after calculation of all explicit deps

    Now we have graph of explicit dependencies builded before calculation
    any implicit dependency in add_dependencies(). This will help to fix
    several bugs and enhance some implicit dependencies calculation in cases,
    when we need all explicit deps to be known.

    Related-Bug: #1626634

    Change-Id: Iebef2600781b867db5925346b444dec4d953aefa

Rabi Mishra (rabi) on 2016-11-17
Changed in heat:
milestone: ocata-1 → ocata-2

Bug 1626619 is now fixed, so I updated the description to be less... future perfect.

description: updated
summary: - OS::Neutron::FloatingIP would have too many dependencies if it didn't
- have too few
+ OS::Neutron::FloatingIP would has too many dependencies
summary: - OS::Neutron::FloatingIP would has too many dependencies
+ OS::Neutron::FloatingIP has too many dependencies
Rabi Mishra (rabi) on 2016-12-14
Changed in heat:
milestone: ocata-2 → ocata-3

Fix proposed to branch: master
Review: https://review.openstack.org/424033

Changed in heat:
assignee: Oleksii Chuprykov (ochuprykov) → Rabi Mishra (rabi)
Rabi Mishra (rabi) on 2017-01-25
Changed in heat:
milestone: ocata-3 → ocata-rc1
Rabi Mishra (rabi) on 2017-01-31
Changed in heat:
assignee: Rabi Mishra (rabi) → nobody
status: In Progress → Triaged
milestone: ocata-rc1 → pike-1
Rico Lin (rico-lin) on 2017-04-11
Changed in heat:
milestone: pike-1 → pike-2
Rico Lin (rico-lin) on 2017-06-07
Changed in heat:
milestone: pike-2 → pike-3
Rico Lin (rico-lin) on 2017-07-31
Changed in heat:
milestone: pike-3 → pike-rc1
Zane Bitter (zaneb) on 2017-07-31
Changed in heat:
milestone: pike-rc1 → next
Changed in heat:
assignee: nobody → Zane Bitter (zaneb)
status: Triaged → In Progress
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers