When creating a nested stack and pre-storing the raw template, we use a try/finally block to ensure that if the stack creation was never started (e.g. because the template failed validation at the other end) that we would delete the raw template again rather than leave it lying around in the DB. However, this catches too broad a range of exceptions. If an exception such as GreenletExit occurs inside this block, then we will attempt to delete the raw template, resulting in a DB IntegrityError either there (because the template id is already referenced by a stack) or when trying to store the stack (because the template is gone) - whichever happens second.
Prior to https://review.openstack.org/#/c/369827/ being merged, this could be reproduced fairly easily using the steps from bug 1499669. There's probably no way to trigger it any more with that change merged, but it would be nice to tidy this up.
Reviewed: https:/
Committed: https:/
Submitter: Jenkins
Branch: master
commit 55c21c18e645551
Author: Zane Bitter <email address hidden>
Date: Wed Sep 21 14:57:22 2016 -0400
Don't delete RawTemplate if it referenced by a stack
When creating a nested stack and pre-storing the raw template, we
previously used a try/finally block to ensure that if the stack creation
was never started (e.g. because the template failed validation at the other
end) that we would delete the raw template again rather than leave it lying
around in the DB. However, this catches too broad a range of exceptions. If
an exception such as GreenletExit occurs inside this block, then we will
attempt to delete the raw template, resulting in a DB IntegrityError either
here (because the template id is already referenced by a stack) or when
trying to store the stack (because the template is gone).
Resolve this by only doing the cleanup on HeatExceptions, which indicates
that the other engine has bailed out without storing the stack.
Change-Id: Ie24a82b7ce1628
Closes-Bug: #1626256