Nested validation breaks with ResourceGroup and non-defaulted count parameter

Bug #1626025 reported by Steven Hardy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Thomas Herve

Bug Description

[stack@instack ~]$ heat template-validate -f rg.yaml --show-nested
ERROR: The Parameter (the_count) was not provided.

[stack@instack ~]$ cat rg.yaml
heat_template_version: 2016-10-14

parameters:
  the_count:
    type: number

resources:

  the_group:
    type: OS::Heat::ResourceGroup
    properties:
      count: {get_param: the_count}
      resource_def:
        type: OS::Heat::RandomString

We're validating the count too eagerly, but I'm not sure what value we can pass (zero?) which will enable the nested validation to work in this case.

Thomas Herve (therve)
Changed in heat:
milestone: none → ongoing
importance: Undecided → Medium
Thomas Herve (therve)
Changed in heat:
assignee: nobody → Thomas Herve (therve)
milestone: ongoing → ocata-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/374226

Changed in heat:
status: New → In Progress
Rabi Mishra (rabi)
Changed in heat:
milestone: ocata-1 → ocata-2
Rabi Mishra (rabi)
Changed in heat:
milestone: ocata-2 → ocata-3
Thomas Herve (therve)
Changed in heat:
assignee: Thomas Herve (therve) → nobody
status: In Progress → Confirmed
milestone: ocata-3 → next
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Thomas Herve (<email address hidden>) on branch: master
Review: https://review.openstack.org/374226

Changed in heat:
assignee: nobody → Thomas Herve (therve)
status: Confirmed → In Progress
Thomas Herve (therve)
Changed in heat:
milestone: next → rocky-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/547055
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=9f73a232d766a3d7f3baac149c587db99b92aa81
Submitter: Zuul
Branch: master

commit 9f73a232d766a3d7f3baac149c587db99b92aa81
Author: Thomas Herve <email address hidden>
Date: Thu Feb 22 17:07:47 2018 +0100

    Return nested parameters for resource group.

    This refactors the building of schema from parameter validation to use a
    new method (which doesn't keep stacks in memory), and use that new
    method for providing proper schema for resource group when the size is
    0.

    Change-Id: Id3020e8f3fd94e2cef413d5eb9de9d1cd16ddeaa
    Closes-Bug: #1751074
    Closes-Bug: #1626025

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/548640

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/queens)

Reviewed: https://review.openstack.org/548640
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=160a6fcabe7f43357060025f97cd21bc24385671
Submitter: Zuul
Branch: stable/queens

commit 160a6fcabe7f43357060025f97cd21bc24385671
Author: Thomas Herve <email address hidden>
Date: Thu Feb 22 17:07:47 2018 +0100

    Return nested parameters for resource group.

    This refactors the building of schema from parameter validation to use a
    new method (which doesn't keep stacks in memory), and use that new
    method for providing proper schema for resource group when the size is
    0.

    Change-Id: Id3020e8f3fd94e2cef413d5eb9de9d1cd16ddeaa
    Closes-Bug: #1751074
    Closes-Bug: #1626025
    (cherry picked from commit 9f73a232d766a3d7f3baac149c587db99b92aa81)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 11.0.0.0b1

This issue was fixed in the openstack/heat 11.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 10.0.1

This issue was fixed in the openstack/heat 10.0.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.