heat logs missing modules as exceptions

Bug #1597593 reported by Amit Ugol on 2016-06-30
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Low
Jason Dunsmore

Bug Description

When heat engine starts up it will log missing modules as exceptions:

2016-06-29 07:51:05.630 18044 ERROR stevedore.extension [-] Could not load 'manila': No module named manilaclient
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension [-] No module named manilaclient
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension Traceback (most recent call last):
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension File "/usr/lib/python2.7/site-packages/stevedore/extension.py", line 163, in _load_plugins
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension verify_requirements,
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension File "/usr/lib/python2.7/site-packages/stevedore/enabled.py", line 67, in _load_one_plugin
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension verify_requirements,
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension File "/usr/lib/python2.7/site-packages/stevedore/extension.py", line 186, in _load_one_plugin
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension plugin = ep.load(require=verify_requirements)
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension File "/usr/lib/python2.7/site-packages/pkg_resources.py", line 2260, in load
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension entry = __import__(self.module_name, globals(),globals(), ['__name__'])
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension File "/usr/lib/python2.7/site-packages/heat/engine/clients/os/manila.py", line 17, in <module>
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension from manilaclient import client as manila_client
2016-06-29 07:51:05.630 18044 ERROR stevedore.extension ImportError: No module named manilaclient

The desirable behavior here would be to change the error message here to something like:
"'manila' is not installed so not using that" and the change the trace log level to debug.

Tags: log Edit Tag help
Amit Ugol (amit-ugol) on 2016-06-30
tags: added: log
Changed in heat:
assignee: nobody → Jason Dunsmore (jasondunsmore)

Fix proposed to branch: master
Review: https://review.openstack.org/336288

Changed in heat:
status: New → In Progress
zhaozhilong (zhaozhilong) wrote :

This is normal. Heat call other items of the pythonclient project, but you do not have to install the environment of the corresponding components. This does not affect the use of heat.

Steven Hardy (shardy) wrote :

It is normal, which is why logging it as an error is a bug.

Changed in heat:
importance: Undecided → Low
milestone: none → newton-3

Reviewed: https://review.openstack.org/336288
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=bd1ea9e874ad269b6a66ff568dfa68f26eedb924
Submitter: Jenkins
Branch: master

commit bd1ea9e874ad269b6a66ff568dfa68f26eedb924
Author: Jason Dunsmore <email address hidden>
Date: Thu Jun 30 15:50:42 2016 -0500

    Log missing clients as WARNING instead of ERROR

    This will prevent tracebacks from being logged if every client is not
    installed when the engine is started.

    Change-Id: I53c90f98689070a0b18e49ca7988e4176a8987ac
    Closes-Bug: #1597593

Changed in heat:
status: In Progress → Fix Released

This issue was fixed in the openstack/heat 7.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers