UpdatePortTest fails with various errors

[Thomas Herve]

Got a bunch of failures today. Some on test_stack_update_replace_with_ip_after_failed_update

      File "/opt/stack/new/heat/heat_integrationtests/functional/test_create_update_neutron_port.py", line 126, in test_stack_update_replace_with_ip_after_failed_update
        stack_identifier = self.stack_create(template=test_template)
      File "/opt/stack/new/heat/heat_integrationtests/common/test.py", line 517, in stack_create
        self._wait_for_stack_status(**kwargs)
      File "/opt/stack/new/heat/heat_integrationtests/common/test.py", line 334, in _wait_for_stack_status
        fail_regexp):
      File "/opt/stack/new/heat/heat_integrationtests/common/test.py", line 300, in _verify_status
        stack_status_reason=stack.stack_status_reason)
    heat_integrationtests.common.exceptions.StackBuildErrorException: Stack UpdatePortTest-93146945/7913c628-602d-4fed-8cff-218affcd7f6a is in CREATE_FAILED status due to 'Resource CREATE failed: IpAddressInUseClient: resources.port: Unable to complete operation for network 06f6c237-0e64-456d-b92b-43c0fd566d7c. The IP address 11.11.11.11 is in use.
    Neutron server returns request_ids: ['req-3236072e-ffb8-4171-9f8e-7c6e7235900c']'

Some on test_stack_update_replace_no_ip:

      File "/opt/stack/new/heat/heat_integrationtests/functional/test_create_update_neutron_port.py", line 77, in test_stack_update_replace_no_ip
        self.assertNotEqual(_ip, new_ip)
      File "/opt/stack/new/heat/.tox/integration/local/lib/python2.7/site-packages/unittest2/case.py", line 845, in assertNotEqual
        raise self.failureException(msg)
    AssertionError: u'11.11.11.12' == u'11.11.11.12'

test_stack_update_replace_with_ip_rollback seems to fail like the first one too.

[Thomas Herve (therve)]

Some of the logs here: http://eavesdrop.openstack.org/irclogs/%23openstack-neutron/%23openstack-neutron.2016-06-10.log.html

To summarize, the IP pool is more aggressively managed in Neutron since https://review.openstack.org/#/c/292207/ got merged. We had 2 main issues that I could see:

* The DHCP port that the subnet automatically creates can take the 11.11.11.11 IP that we try to allocate later on in the template. To fix, I disabled DHCP in the subnet
* The IP doesn't necessarily change when we remove the fixed IP. Those assertions shouldn't be necessary for the tests anymore.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/328343
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d9855dfe0b7c13ca3ae64d62e0c28062c1f90951
Submitter: Jenkins
Branch: master

commit d9855dfe0b7c13ca3ae64d62e0c28062c1f90951
Author: Thomas Herve <email address hidden>
Date: Fri Jun 10 17:21:34 2016 +0200

    Fix tests on Neutron port behavior

    Fix some integration tests checking port behavior, as the assumptions we
    were making were wrong, and that changed recently.

    Closes-Bug: #1591177
    Change-Id: I4338eee40d092148831b3e20f8a42a1b3d3ea8bf

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/heat 7.0.0.0b2 development milestone.