CI is failing due to invalid property 'timeout'

[Juan Antonio Osorio Robles]

Lately several jobs in TripleO have been failing with a similar trace:

2016-05-17 03:19:17.112 | 2016-05-17 03:18:57 [0]: CREATE_FAILED KeyError: resources[0].resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.112 | 2016-05-17 03:18:57 [overcloud-Compute-pzsycngb33sn-0-chyagu6ugu4v]: CREATE_FAILED Resource CREATE failed: KeyError: resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.112 | 2016-05-17 03:18:58 [NetworkConfig]: CREATE_IN_PROGRESS state changed
2016-05-17 03:19:17.113 | 2016-05-17 03:18:59 [overcloud-Compute-pzsycngb33sn]: CREATE_FAILED Resource CREATE failed: KeyError: resources[0].resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.113 | 2016-05-17 03:19:00 [UpdateDeployment]: CREATE_COMPLETE state changed
2016-05-17 03:19:17.113 | 2016-05-17 03:19:00 [NetworkDeployment]: CREATE_FAILED KeyError: resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.113 | 2016-05-17 03:19:01 [overcloud-Controller-rfaansaafp3e-0-bvljsw4wrkbl]: CREATE_FAILED Resource CREATE failed: KeyError: resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.113 | 2016-05-17 03:19:01 [NetworkConfig]: CREATE_COMPLETE state changed
2016-05-17 03:19:17.113 | 2016-05-17 03:19:01 [0]: CREATE_FAILED KeyError: resources[0].resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.113 | 2016-05-17 03:19:02 [NetIpMap]: CREATE_COMPLETE state changed
2016-05-17 03:19:17.114 | 2016-05-17 03:19:03 [NetIpSubnetMap]: CREATE_COMPLETE state changed
2016-05-17 03:19:17.114 | 2016-05-17 03:19:03 [NetworkDeployment]: CREATE_IN_PROGRESS state changed
2016-05-17 03:19:17.114 | 2016-05-17 03:19:03 [overcloud-Controller-rfaansaafp3e]: CREATE_FAILED Resource CREATE failed: KeyError: resources[0].resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.114 | 2016-05-17 03:19:04 [Controller]: CREATE_FAILED KeyError: resources.Controller.resources[0].resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.114 | 2016-05-17 03:19:05 [NetworkDeployment]: CREATE_FAILED KeyError: resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.114 | 2016-05-17 03:19:06 [overcloud-CephStorage-l7jm6ld4qfnq-0-mbaf6znfnxlz]: CREATE_FAILED Resource CREATE failed: KeyError: resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.115 | 2016-05-17 03:19:07 [0]: CREATE_FAILED KeyError: resources[0].resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.115 | 2016-05-17 03:19:07 [NetworkDeployment]: SIGNAL_FAILED Signal: deployment cfc78726-cdf3-4ff6-ad53-899d5dff698f succeeded
2016-05-17 03:19:17.705 | 2016-05-17 03:19:08 [CephStorage]: CREATE_FAILED KeyError: resources.CephStorage.resources[0].resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.705 | 2016-05-17 03:19:08 [overcloud-CephStorage-l7jm6ld4qfnq]: CREATE_FAILED Resource CREATE failed: KeyError: resources[0].resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.705 | 2016-05-17 03:19:09 [overcloud]: CREATE_FAILED Resource CREATE failed: KeyError: resources.Compute.resources[0].resources.NetworkDeployment: u'Invalid Property timeout'
2016-05-17 03:19:17.705 | 2016-05-17 03:19:10 [NetworkDeployment]: SIGNAL_FAILED Signal: deployment c439e1e8-472b-4c6a-8920-1f1baad4a3cc succeeded
2016-05-17 03:19:17.706 | Stack overcloud CREATE_FAILED

And these jobs started failing with the addition of the timeout which was introduced in this patch https://review.openstack.org/#/c/295992/14 the reason is that there is an attempt to get self.properties[self.TIMEOUT], which assumes timeout is defined. instead, we need to make that optional.

[Juan Antonio Osorio Robles (juan-osorio-robles)]

Well, this seems related

[Juan Antonio Osorio Robles (juan-osorio-robles)]

Yeah, it seems to be related to this https://review.openstack.org/#/c/295992 . So it's failing because it tries to get self.TIMEOUT and we're not specifying one and it seems it mandatory now

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/317286

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/317292

[OpenStack Infra (hudson-openstack)]

Change abandoned by Juan Antonio Osorio Robles (<email address hidden>) on branch: master
Review: https://review.openstack.org/317286
Reason: submitted a revert instead

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/317292
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=4181edae06210a0ea0943ea2527deb8db88a4fe2
Submitter: Jenkins
Branch: master

commit 4181edae06210a0ea0943ea2527deb8db88a4fe2
Author: Juan Antonio Osorio Robles <email address hidden>
Date: Tue May 17 10:41:54 2016 +0300

    Revert "Add timeout for software deployments"

    This reverts commit a3a0cece4966149b4c0a6f86fec6506c33e5dbe7.

    This doesn't take into account StructuredDeployments; it was
    identified in failures in TripleO

    Change-Id: I0cc8f72dd583e1360bade7da01b077bcca01df02
    Closes-Bug: #1582556

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/heat 7.0.0.0b1 development milestone.