heat-template zuul faliure

[Kanagaraj Manickam]

heat-template jobs fails with below kind of error
Got error validating /opt/stack/new/heat-templates/hotputtserver_with_encrpyted_volume.yaml , ERROR: HEAT-E99001 Service cinder is not available for resource type OS::Cinder::EncryptedVolumeType, reason: Service endpoint not in service catalog.

[Mark Vanderwiel (vanderwl)]

I created this patch just before this bug was reported: https://review.openstack.org/#/c/290147/

[Mark Vanderwiel (vanderwl)]

With your patch to ignore Service errors (99001) https://review.openstack.org/#/c/289751, the next error that pops up is for "ERROR: The Parameter (public_net_id) was not provided.". These tool script does not provide any parameters, so is making this call to validate even worth doing here?

[Kanagaraj Manickam (kanagaraj-manickam)]

Mark, This patch is required to arrest the service unavailabilty error. and I am assming that there is an bug in heat side that is if translation is provided between required and optional properties, which is initialized with input parameter in the template and if that input parameter is not given, this kind errors occur, especially it happens in Neutron Port [1] and FloatingIps [2].

[1] https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/neutron/port.py#L348
[2] https://github.com/openstack/heat/blob/master/heat/engine/resources/openstack/neutron/floatingip.py#L142

But even after these issue fixed, still there are circular reference, which needs to be fxied on heat-template repo.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/291021

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/290301
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=0bf9463bfceb25d7b98a8fdd84b61521b8c013cb
Submitter: Jenkins
Branch: master

commit 0bf9463bfceb25d7b98a8fdd84b61521b8c013cb
Author: Rabi Mishra <email address hidden>
Date: Wed Mar 9 11:33:49 2016 +0530

    Don't RESOLVE translate in resource init

    We can completely remove 'RESOLVE' translations involving client
    lookups in resource init. As we are doing translation before create
    and update, it seems we can avoid it.

    However, we would need other translations, like 'REPLACE' for property
    vaidations(ex. required properties that would be replaced by deprecated
    properties). This would be done only when strict_validate=True to avoid
    this with template-validate.

    Change-Id: Ie80bdd10726a8fc8a8787b78db93acffd333137f
    Closes-Bug: #1554927
    Partial-Bug: #1554380

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/291021
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d12cbe7959df33ccbba31878b3049b169db86857
Submitter: Jenkins
Branch: master

commit d12cbe7959df33ccbba31878b3049b169db86857
Author: Kanagaraj Manickam <email address hidden>
Date: Thu Mar 10 19:18:42 2016 +0530

    Skip the in-built dependencies while validating template

    There are many neutron and nova resource has in-built
    dependencies by using add_dependencies() method. Its not
    required to validate them while valding the user template,
    as
    1. user interest will be validaing their template
    2. in-built dependencies are not known to user.

    Co-Authored-By: Rabi Mishra <email address hidden>
    Change-Id: I4a3043fd17b69a346d447dfbd17488040cf9b387
    Related-bug: #1554380