Avoid db warnings for too-large events

Bug #1552431 reported by Crag Wolfe
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Crag Wolfe

Bug Description

The problem with the fix for https://bugs.launchpad.net/heat/+bug/1493858 is that even though we catch the db exception (perhaps multiple times), we still get a log message (perhaps multiple times) beginning with "ERROR oslo_db.sqlalchemy.exc_filters [-] DBAPIError exception wrapped from..." *with* the payload of what it wasn't able to store (at least 2^16 bytes). This tends to grab the attention of operators who can waste a lot of time on it, even if it is not a "real" problem.

Revision history for this message
Crag Wolfe (cwolfe) wrote :

The related bug, https://bugs.launchpad.net/heat/+bug/1524013 , targets coming up with a data model change so that we can store really large events.

This bug is just concerned with avoiding the needless oslo_db error message (no data model change).

Changed in heat:
assignee: nobody → Crag Wolfe (cwolfe)
status: New → In Progress
Changed in heat:
importance: Undecided → Medium
milestone: none → mitaka-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/259274
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b48452fc9acd4e4c9f8fd83ca1fc9782635cec36
Submitter: Jenkins
Branch: master

commit b48452fc9acd4e4c9f8fd83ca1fc9782635cec36
Author: Crag Wolfe <email address hidden>
Date: Thu Dec 17 23:28:15 2015 -0500

    Do not try to save event resource if too big for db column

    Change-Id: Idedcfb5bf6678cd24990d1503c223ea9a9ac41cf
    Closes-Bug: #1552431

Changed in heat:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/290916

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0rc1

This issue was fixed in the openstack/heat 6.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/liberty)

Reviewed: https://review.openstack.org/290916
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=17c6422cd4b495c41c0d3cee5e30c337361bad8e
Submitter: Jenkins
Branch: stable/liberty

commit 17c6422cd4b495c41c0d3cee5e30c337361bad8e
Author: Crag Wolfe <email address hidden>
Date: Thu Dec 17 23:28:15 2015 -0500

    Do not try to save event resource if too big for db column

    Change-Id: Idedcfb5bf6678cd24990d1503c223ea9a9ac41cf
    Closes-Bug: #1552431
    (cherry picked from commit b48452fc9acd4e4c9f8fd83ca1fc9782635cec36)

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/heat 5.0.2

This issue was fixed in the openstack/heat 5.0.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.