Convergence: after a cancel update request, stack does not delete

[Sabeen]

After issuing a cancel update request (which is also not working - https://bugs.launchpad.net/heat/+bug/1533176), when I try to delete the stack, it goes into DELETE_IN_PROGRESS status and stays there. It does not delete the stack.

Here is a test for cancel stack update: https://review.openstack.org/#/c/270488/, in the convergence logs you'll see that it fails because cancel stack update is not working and Stack failed to reach DELETE_COMPLETE status within the required time (1200 s).

[Anant Patil (ananta)]

Thanks Sabeen for the patch. In convergence, the previous operations on active resources are never abruptly stopped, so they continue till they are over. This will be stuck when the resource is waiting for signal from an instance and the instance is not capable of doing so. We are addressing this in bug#153376

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/301483

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/343076

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/354000

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/343076
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=9c79ee4d69e9a264c90579dcaa798dc725def0c9
Submitter: Jenkins
Branch: master

commit 9c79ee4d69e9a264c90579dcaa798dc725def0c9
Author: Zane Bitter <email address hidden>
Date: Mon Jul 25 09:57:48 2016 -0400

    Add interrupt points for convergence check-resource operations

    This allows a convergence operation to be cancelled at an appropriate point
    (i.e. between steps in a task) by sending a message to a queue.

    Note that there's no code yet to actually cancel any operations
    (specifically, sending a cancel message to the stack will _not_ cause the
    check_resource operations to be cancelled under convergence).

    Change-Id: I9469c31de5e40334083ef1dd20243f2f6779549e
    Related-Bug: #1545063
    Co-Authored-By: Anant Patil <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/354000
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6dc3ab9b01c89e0eb6695daa140679661f266519
Submitter: Jenkins
Branch: master

commit 6dc3ab9b01c89e0eb6695daa140679661f266519
Author: Anant Patil <email address hidden>
Date: Tue Sep 6 13:28:53 2016 +0530

    Deletion of in-progress stack

    Unlike in legacy engine case, the stack in in-progress state couldn't be
    deleted in convergence. This patch fixes this issue so that the
    behaviour is compatible.

    Change-Id: I79bb14d5d7744ba2a012e23e690608dc7db1fbc5
    Closes-Bug: #1545063
    Closes-Bug: #1592374

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 7.0.0.0rc1 release candidate.