test_asg_notifications fails in convergence tests

[Thomas Herve]

This is a relatively new failure to me, seen here for example: http://logs.openstack.org/22/252522/8/check/gate-heat-dsvm-functional-convg-mysql/0abb33c/

The error is : Conflict occurred attempting to store user - Duplicate Entry.

It seems we try to create the scaling policy twice? There is possibly a race when we call _create_user twice in a row without data being updated.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/280129

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/280142

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/280129
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=483776988c047a96b04472b20f60424e98edd45d
Submitter: Jenkins
Branch: master

commit 483776988c047a96b04472b20f60424e98edd45d
Author: Thomas Herve <email address hidden>
Date: Mon Feb 15 10:51:37 2016 +0100

    Check for resource_id when resolving attributes

    Trying to resolve attributes while stack is in creation can lead to data
    corruption on resources using StackUser that create data on demand. It's
    safer to protect attribute resolution on the presence of resource_id for
    those classes.

    Change-Id: Ifcce948c15e42c787c44b2a1daf4d97bc91305a7
    Closes-Bug: #1541323

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/280142
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=259899166a652abfbbc0cf93027c9d1af1c24079
Submitter: Jenkins
Branch: master

commit 259899166a652abfbbc0cf93027c9d1af1c24079
Author: Sergey Kraynev <email address hidden>
Date: Mon Feb 15 05:24:17 2016 -0500

    Don't resolve outputs during polling stack status

    This patch makes optimization for polling requests, which check stack
    status. It doesn't require to resolve outputs, when stack object is used
    only for checking status and getting stack_id.

    Related-Bug: #1541323

    Change-Id: Ic1f4c1f15183c957e022f36bda26fed48096502e

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/heat 6.0.0.0b3 development milestone.