SoftwareDeployments -> SoftwareDeploymentGroup update is destructive

[Steven Hardy]

If you attempt to update a stack containing OS::Heat::SoftwareDeployments resources, so it uses the new non-deprecated OS::Heat::SoftwareDeploymentGroup type instead, it deletes the group, and all of the deployments.

This means that any deployment "actions" property will be misinterpreted, e.g if you have actions: CREATE, all the deployments will re-run on the update, even though it's an update, not a create.

We need a way to ensure the update updates the existing resource in-place, without deleting the entire nested stack containing all the Deployment resources.

[Steven Hardy (shardy)]

Rico - are you looking at this or can I go ahead and post a patch myself?

[Rico Lin (rico-lin)]

I'm looking at this patch right now, but not yet start hacking. Feel free to post any patch you wante. :)

[Rico Lin (rico-lin)]

Start hacking now, still feel free to take over or otherwise :)

[Rico Lin (rico-lin)]

https://review.openstack.org/#/c/280201/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/280201
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3aeaefc29f27b7e55a0e646b39a5522fb11ccf6c
Submitter: Jenkins
Branch: master

commit 3aeaefc29f27b7e55a0e646b39a5522fb11ccf6c
Author: ricolin <email address hidden>
Date: Sun Apr 3 17:34:52 2016 +0800

    Non-destructive upgrade for deprecated resources

    If you attempt to update a stack containing
    OS::Heat::SoftwareDeployments resources, so it uses the new
    non-deprecated OS::Heat::SoftwareDeploymentGroup type instead, it
    deletes the group, and all of the deployments.

    This means that any deployment "actions" property will be
    misinterpreted, e.g if you have actions: CREATE, all the deployments
    will re-run on the update, even though it's an update, not a create.

    This issue exists on all deprecated resoruces, when we trying to upgrade
    to new version of it by update.

    This patch fix above update issue by check if resoruce was deprecated
    and been update by replacing resource (which is the parent class of
    existing resource).

    Change-Id: Ib7880120a90c4497a7ceea53eee55c220a28d14e
    Closes-Bug: #1528958

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/368275

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/heat 7.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rico Lin (<email address hidden>) on branch: stable/mitaka
Review: https://review.openstack.org/368275