docker-py mem_limit has been moved to host_config in API version 1.19

Bug #1521109 reported by Jiri Suchomel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Undecided
Jiri Suchomel

Bug Description

In recent versions of docker-py (actually since docker-py 1.3.0), mem_limit argument is not expected in create_container_config function, otherwise exception with "mem_limit has been moved to host_config in API version 1.19" is thown

See
https://github.com/docker/docker-py/commit/427e3a60232a5b8ba6c2b91005908321366a0113

However, heat/docker/docker_container.py is still using it. It should be enough if the default value for mem_limit would be None instead of current 0

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/251257

Changed in heat:
assignee: nobody → Jiri Suchomel (jsuchome)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/251257
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b78f5189d175b954c27b0afb4742517d2a189d0e
Submitter: Jenkins
Branch: master

commit b78f5189d175b954c27b0afb4742517d2a189d0e
Author: Jiří Suchomel <email address hidden>
Date: Mon Nov 30 10:25:09 2015 +0100

    Remove default value for mem_limit to keep up with docker-py

    Change-Id: I04d9be374de7bf00cf89cc6e24aa749cb6686a16
    Closes-Bug: 1521109

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/251433

Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/heat 6.0.0.0b1

This issue was fixed in the openstack/heat 6.0.0.0b1 development milestone.

Changed in heat:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (stable/liberty)

Change abandoned by Sergey Kraynev (<email address hidden>) on branch: stable/liberty
Review: https://review.openstack.org/251433
Reason: According decision on weekly team meeting, we need to abandon this patch due to EOL for liberty and broken gate state.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.