Changing Server flavor property specified ID with name occurres error

[Peter Razumovsky]

Steps to reproduce:
1. flavor m1.small has id 2.
2. template:

heat_template_version: 2015-10-15
parameters:
  image:
    type: string
resources:
  server:
    type: OS::Nova::Server
    properties:
      flavor: 2
      image: { get_param: image }

3. create a stack - CREATE_COMPLETE
4. template to update:

heat_template_version: 2015-10-15
parameters:
  image:
    type: string
resources:
  server:
    type: OS::Nova::Server
    properties:
      flavor: m1.small
      image: { get_param: image }

5. update a stack - UPDATE_FAILED, reason - BadRequest: Resize requires a flavor change. (HTTP 400)

Traceback:
Traceback (most recent call last):
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resource.py", line 633, in _action_recorder
2015-11-20 12:28:02.702 TRACE heat.engine.resource yield
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resource.py", line 965, in update
2015-11-20 12:28:02.702 TRACE heat.engine.resource prop_diff])
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/scheduler.py", line 312, in wrapper
2015-11-20 12:28:02.702 TRACE heat.engine.resource step = next(subtask)
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resource.py", line 677, in action_handler_task
2015-11-20 12:28:02.702 TRACE heat.engine.resource while not check(handler_data):
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/resources/openstack/nova/server.py", line 1099, in check_update_complete
2015-11-20 12:28:02.702 TRACE heat.engine.resource **prg.handler_kwargs)
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/opt/stack/heat/heat/engine/clients/os/nova.py", line 433, in resize
2015-11-20 12:28:02.702 TRACE heat.engine.resource server.resize(flavor_id)
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/novaclient/v2/servers.py", line 297, in resize
2015-11-20 12:28:02.702 TRACE heat.engine.resource self.manager.resize(self, flavor, **kwargs)
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/novaclient/v2/servers.py", line 1114, in resize
2015-11-20 12:28:02.702 TRACE heat.engine.resource self._action('resize', server, info=info, **kwargs)
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/novaclient/v2/servers.py", line 1332, in _action
2015-11-20 12:28:02.702 TRACE heat.engine.resource return self.api.client.post(url, body=body)
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/novaclient/client.py", line 449, in post
2015-11-20 12:28:02.702 TRACE heat.engine.resource return self._cs_request(url, 'POST', **kwargs)
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/novaclient/client.py", line 424, in _cs_request
2015-11-20 12:28:02.702 TRACE heat.engine.resource resp, body = self._time_request(url, method, **kwargs)
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/novaclient/client.py", line 397, in _time_request
2015-11-20 12:28:02.702 TRACE heat.engine.resource resp, body = self.request(url, method, **kwargs)
2015-11-20 12:28:02.702 TRACE heat.engine.resource File "/usr/local/lib/python2.7/dist-packages/novaclient/client.py", line 391, in request
2015-11-20 12:28:02.702 TRACE heat.engine.resource raise exceptions.from_response(resp, body, url, method)
2015-11-20 12:28:02.702 TRACE heat.engine.resource BadRequest: Resize requires a flavor change. (HTTP 400) (Request-ID: req-1ab974dc-1165-4230-b5e7-48915a339100)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/248007

[Sergey Kraynev (skraynev)]

According comments on review, it requires additional discussion.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Peter Razumovsky (<email address hidden>) on branch: master
Review: https://review.openstack.org/248007