purge_deleted doesn't handle prev_raw_template_id

[Thomas Herve]

We added storage of previous template in the prev_raw_template_id column of the stack db for convergence. We also use it in the non-convergence case.

Unfortunately we delete templates which are not referenced by raw_template_id in purge_deleted. We should check this column as well.

[Thomas Herve (therve)]

It was the other way around, we delete the ones even on non-deleted stack.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235132

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235132
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=78d5c425d0a5573de187c83705f4b6c034fc441d
Submitter: Jenkins
Branch: master

commit 78d5c425d0a5573de187c83705f4b6c034fc441d
Author: Thomas Herve <email address hidden>
Date: Thu Oct 15 09:31:30 2015 +0200

    Fix purging of raw_template rows

    Templates referenced in the prev_raw_template_id column of the stack
    table are not filtered by the purge_deleted script and end up being
    removed. This fixes it by making sure that we consider them when
    filtering.

    Change-Id: I8bab657dfe77b7cef5971e370f6b4f9825a22ba8
    Closes-Bug: #1506079

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/242288

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/242288
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=3000b92004ec2744fc10c84c410b2d4fbb8902e6
Submitter: Jenkins
Branch: stable/liberty

commit 3000b92004ec2744fc10c84c410b2d4fbb8902e6
Author: Thomas Herve <email address hidden>
Date: Thu Oct 15 09:31:30 2015 +0200

    Fix purging of raw_template rows

    Templates referenced in the prev_raw_template_id column of the stack
    table are not filtered by the purge_deleted script and end up being
    removed. This fixes it by making sure that we consider them when
    filtering.

    Change-Id: I8bab657dfe77b7cef5971e370f6b4f9825a22ba8
    Closes-Bug: #1506079
    (cherry picked from commit 78d5c425d0a5573de187c83705f4b6c034fc441d)

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/heat 6.0.0.0b1 development milestone.

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/heat 5.0.1 release.