cannot resume a stack after it was action-checked while suspended

[Removed by request]

A stack cannot resume, since state CHECK_COMPLETE is invalid for resuming.
IMO safest thing here is to disable check on a suspended stack.

[Sergey Kraynev (skraynev)]

Amit, I thought about it several times, but looks like it will not do it more safer...
Probably the right solution is to revise events for previous states and if it was suspended before the check or something else (what allowed after suspend) we may do resume.
I am not the fan of the simple disabling such check.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/237427

[Sergey Kraynev (skraynev)]

I have moved this bug to M2, because IMO it takes additional discussion for patch introduced on review.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Masco (<email address hidden>) on branch: master
Review: https://review.openstack.org/237427
Reason: not a correct way of solving this problem.

[Di XiaoLi (dixiaoli)]

for the situation:
Stack Create -> Stack Suspend -> Stack Check -> Stack Resume
stack resume will fail for State (u'CHECK', u'COMPLETE') invalid for resume.

IMO, we can do like this under this situation :
Stack Create -> Stack Suspend -> Stack Check -> Stack Resume -> Stack Suspend -> Stack Resume
So, we can fix this bug by adding the hint like this:
def resume(self):
        """Resume the resource.
        if self.state not in ((self.SUSPEND, self.COMPLETE),
                                         (self.RESUME, self.FAILED),
                                         (self.RESUME, self.COMPLETE)):
            exc = exception.Error(_('State %s invalid for resume, you must execute suspend first and then execute resume.')
                                  % six.text_type(self.state))
            raise exception.ResourceFailure(exc, self, action)
        LOG.info(_LI('resuming %s'), six.text_type(self))
        return self._do_action(action)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/304502

[OpenStack Infra (hudson-openstack)]

Change abandoned by Di XiaoLi (<email address hidden>) on branch: master
Review: https://review.openstack.org/304502
Reason: Abandoned as it is not a good way of solving bug 1506042

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/362319

[OpenStack Infra (hudson-openstack)]

Change abandoned by Zane Bitter (<email address hidden>) on branch: master
Review: https://review.opendev.org/362319