Empty data can be cause of some errors during deleting backup stack

Bug #1496909 reported by Sergey Kraynev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Sergey Kraynev
Kilo
Fix Released
Medium
Angus Salkeld

Bug Description

In case when UpdateReplace failed we copy backup resource properties and resource_id [1].
However some resource can contain important (for example used during deletion) information in data.
To avoid potential issues, when data is empty and we can not correctly process it, let's copy resource data from backup resource too.

[1] https://github.com/openstack/heat/blob/master/heat/engine/stack.py#L1251-L1282

Changed in heat:
status: Triaged → In Progress
tags: added: kilo-backport-potential
removed: juno-backport-potential
Angus Salkeld (asalkeld)
tags: removed: kilo-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/220986
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=71268bea28c89599ee113b5d657ff50b5507d0df
Submitter: Jenkins
Branch: master

commit 71268bea28c89599ee113b5d657ff50b5507d0df
Author: Sergey Kraynev <email address hidden>
Date: Mon Sep 7 08:55:55 2015 -0400

    Copy resource data in _delete_backup_stack

    Currently during deleting backup stack we copy properties and
    resource id from new to backup resource and conversely. Same thing
    should be done for resource data, because it may ve also used in some
    deleting operations.

    Change-Id: Id121cf9eb391ad90325934419e635f7afa6f8317
    Closes-Bug: #1496909

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/225538

Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/kilo)

Reviewed: https://review.openstack.org/225538
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=d8bdac7c41e76babff122294aefdc917997f5931
Submitter: Jenkins
Branch: stable/kilo

commit d8bdac7c41e76babff122294aefdc917997f5931
Author: Sergey Kraynev <email address hidden>
Date: Mon Sep 7 08:55:55 2015 -0400

    Copy resource data in _delete_backup_stack

    Currently during deleting backup stack we copy properties and
    resource id from new to backup resource and conversely. Same thing
    should be done for resource data, because it may ve also used in some
    deleting operations.

    Change-Id: Id121cf9eb391ad90325934419e635f7afa6f8317
    Closes-Bug: #1496909
    (cherry picked from commit 71268bea28c89599ee113b5d657ff50b5507d0df)

Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-rc1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.