Software Deployment DELETE action does not work for CFN_SIGNAL

[Rabi Mishra]

For software deployments with 'DELETE' actions, deployment signaling fails when used with CFN_SIGNAL. This happens because the 'deploy_signal_id' passed as part of deployment metadata is NULL.

"deploy_signal_id", "value": null,

We return None from '_get_ec2_signed_url' when action==DELETE

https://github.com/openstack/heat/blob/master/heat/engine/resources/signal_responder.py#L95

[Steven Hardy (shardy)]

I think this is a regression caused here:

https://review.openstack.org/#/c/198183/11/heat/engine/resources/signal_responder.py

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/216223

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/216223
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6c29d7a842d499227bcb16f68a4ff228ed6721b3
Submitter: Jenkins
Branch: master

commit 6c29d7a842d499227bcb16f68a4ff228ed6721b3
Author: Rabi Mishra <email address hidden>
Date: Mon Aug 24 17:19:13 2015 +0530

    Fix Software Deployment DELETE action for CFN_SIGNAL transport

    This is a regression from https://review.openstack.org/#/c/198183.

    Change-Id: I76702f12130e18c9e5f036e9e771e8b44fa8da78
    Closes-Bug: #1488058