TemplateResource schema is not validated when overriding another template

Bug #1479565 reported by Angus Salkeld
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
Angus Salkeld

Bug Description

If I have an environment like this:
resource_registry:
  resources:
    thisone:
      OS::Nova::Server: my_server.yaml

The schema of my_nova.yaml IS validated against the nova properties/attributes
(missing required properties will fail validation)

But if I have the following, concrete.yaml is not validated against facade.yaml

resource_registry:
  OS::Thingy: facade.yaml
  resources:
    thisone:
      OS::Thingy: concrete.yaml

This is inconsistent and needs to be fixed.

Angus Salkeld (asalkeld)
Changed in heat:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Angus Salkeld (asalkeld)
milestone: none → liberty-3
Changed in heat:
status: Triaged → In Progress
Revision history for this message
Angus Salkeld (asalkeld) wrote :
Changed in heat:
milestone: liberty-3 → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/197402
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=b897e7786f1bc29fa1cb75f289328267e0727ca1
Submitter: Jenkins
Branch: master

commit b897e7786f1bc29fa1cb75f289328267e0727ca1
Author: Angus Salkeld <email address hidden>
Date: Wed Aug 5 13:30:26 2015 +1000

    Validate TemplateResource schema when based on other templates

    Currently this is only done if you override a python resource
    and not if you override a template resource.

    Closes-bug: #1479565
    Change-Id: I29f65d5058c8c2e8b04cb1fcbcb4956040ec908a

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-rc1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.