Resources with custom FnGetAtt don't populate attributes on resource-show

Bug #1470675 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Triaged
Medium
Unassigned

Bug Description

Resources with custom FnGetAtt generally bypass self.attributes since their attribute schemas are dynamic (software deployments, template resources, resource groups)

This means that a resource-show on these resources will return 'null' as the value for any defined attribute.

For example, an OS::Heat::SoftwareDeployment will return the following for resource-show| attributes | { |
| | "deploy_stdout": null, |
| | "deploy_stderr": null, |
| | "deploy_status_code": null |
| | }

however doing a heat deployment-show with display actual values for deploy_stdout etc

Likely solutions would be:
1. modify heat.engine.api.format_resource_attributes to take into account resources with custom FnGetAtt and dynamic schemas
2. modify these resources to populate self.attributes with a dynamic schema, and remove their custom FnGetAtt functions

2. may require more effort/magic, but it could also be the basis for fixing bug 1464628

Changed in heat:
status: New → Triaged
importance: Undecided → Medium
Changed in heat:
assignee: nobody → Kairat Kushaev (kkushaev)
Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/206098

Changed in heat:
assignee: Kairat Kushaev (kkushaev) → Angus Salkeld (asalkeld)
Changed in heat:
assignee: Angus Salkeld (asalkeld) → Kairat Kushaev (kkushaev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/210306

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/205128
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=15e52ff5e96f1521d7c06a8d55f62f5fb6ce33d3
Submitter: Jenkins
Branch: master

commit 15e52ff5e96f1521d7c06a8d55f62f5fb6ce33d3
Author: Angus Salkeld <email address hidden>
Date: Tue Aug 4 13:00:40 2015 +1000

    Support attributes with dynamic scheme

    Some resources (software deployment, template resources, etc)
    doesn't have static attribute scheme. So when we are trying
    to output attributes for such resources the output always
    returns None or null. So the patch support this functionality
    with the new type of attributes: dynamic scheme attributes.
    They allow to resolve dynamic attributes for resource outputs
    and fetch such info as nested stack attrs or
    software deployment outputs.
    The next patch will enable usage of dynamic scheme attributes
    for heat resource.

    Change-Id: I474addad0bbfe16aa5c562f2d6025c52f175dd4f
    Partial-Bug: #1470675

Steven Hardy (shardy)
tags: added: kilo-backport-potential
Changed in heat:
milestone: none → liberty-3
Angus Salkeld (asalkeld)
Changed in heat:
milestone: liberty-3 → liberty-rc1
Revision history for this message
Steve Baker (steve-stevebaker) wrote :

Moving to next, this can be brought back to rc1 if it gets reviews

Changed in heat:
milestone: liberty-rc1 → next
tags: added: liberty-rc-potential
Angus Salkeld (asalkeld)
tags: removed: kilo-backport-potential
Changed in heat:
milestone: next → mitaka-1
tags: removed: liberty-rc-potential
Revision history for this message
Angus Salkeld (asalkeld) wrote :

I don't think this needs to go back to kilo. If someone really disagrees, please change the status.

tags: added: liberty-backport-potential
Changed in heat:
milestone: mitaka-1 → mitaka-2
Changed in heat:
milestone: mitaka-2 → mitaka-3
Revision history for this message
Kairat Kushaev (kkushaev) wrote :

Sorry, I don't have enough time to work on this in Mitaka.
So feel free to pick up the work.

Changed in heat:
assignee: Kairat Kushaev (kkushaev) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on heat (master)

Change abandoned by Kairat Kushaev (<email address hidden>) on branch: master
Review: https://review.openstack.org/206098
Reason: Sorry, I don't have enough time to work on this in Mitaka.
So feel free to pick up the work.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Kairat Kushaev (<email address hidden>) on branch: master
Review: https://review.openstack.org/209544
Reason: Sorry, I don't have enough time to work on this in Mitaka.
So feel free to pick up the work.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Kairat Kushaev (<email address hidden>) on branch: master
Review: https://review.openstack.org/210306
Reason: Sorry, I don't have enough time to work on this in Mitaka.
So feel free to pick up the work.

Changed in heat:
milestone: mitaka-3 → newton-1
Thomas Herve (therve)
no longer affects: heat/kilo
Changed in heat:
milestone: newton-1 → next
status: In Progress → Triaged
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.