context.request_context() method is not unit tested

Bug #1464655 reported by Kanagaraj Manickam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Low
Kanagaraj Manickam

Bug Description

Add required test cases for context.request_context() method.

Also this method is not handling the dict to RequestContext properly.

Changed in heat:
assignee: nobody → Kanagaraj Manickam (kanagaraj-manickam)
Revision history for this message
Tatiana Kholkina (tlashchova) wrote :

As I can see tox -ecover shows this method as covered.

Revision history for this message
Kanagaraj Manickam (kanagaraj-manickam) wrote :

I believe its covered because, this method is called for each of the rpc calls in the engine. But its unit tested, which suppose to be done for each and every method, I believe.

Angus Salkeld (asalkeld)
Changed in heat:
importance: Undecided → Low
status: New → Triaged
milestone: none → liberty-1
description: updated
Changed in heat:
milestone: liberty-1 → liberty-2
Changed in heat:
status: Triaged → In Progress
Revision history for this message
Thomas Herve (therve) wrote :

I don't understand the second part of your bug. What does "properly" means? When is that an issue?

Changed in heat:
milestone: liberty-2 → liberty-3
Changed in heat:
milestone: liberty-3 → liberty-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/191040
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=0576316ac40b5abb4d5dc4293a5a83f422387eb0
Submitter: Jenkins
Branch: master

commit 0576316ac40b5abb4d5dc4293a5a83f422387eb0
Author: Kanagaraj Manickam <email address hidden>
Date: Thu Aug 20 14:56:55 2015 +0530

    Removes dead code from context.request_context

    Existing context.request_context() method has invalid
    code which try to create RequestConext, but its not used
    in heat anywhere. so those dead code is removed from heat.

    Closes-bug: #1464655

    Change-Id: Icb60f1ba40853523ef35730c2ba5bda6e5970771

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: liberty-rc1 → 5.0.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.