Heat: Failed to validate parameter errors

[Dan Prince]

As of today we are seeing heat stack-create errors when using overcloud-without-mergepy.yaml.

+ heat stack-create -e /home/dprince/overcloud-env.json -e /home/dprince/tripleo-heat-templates/overcloud-resource-registry-puppet.yaml -t 360 -f /home/dprince/tripleo-heat-templates/overcloud-without-mergepy.yaml -P ExtraConfig= overcloud
ERROR: Failed to validate: ControllerRingbuilderPuppetDeployment: servers The Parameter (servers) was not provided.

[Jay Dobies (jdob)]

I was seeing this with a slightly different error:

Property error : SwiftDevicesAndProxyConfigImpl: config The Parameter (object_store_swift_devices) was not provided.

From the same call:

heat stack-create -e /opt/tripleo-root/overcloud-env.json -e /opt/tripleo-root/tripleo-heat-templates/overcloud-resource-registry.yaml -t 360 -f /opt/tripleo-root/tripleo-heat-templates/overcloud-without-mergepy.yaml -P ExtraConfig= overcloud

[Dan Prince (dan-prince)]

Trying a temprevert here: https://review.openstack.org/158832

[Dan Prince (dan-prince)]

The full CI log file is here: http://logs.openstack.org/30/141530/11/experimental-tripleo/check-tripleo-ironic-overcloud-f20-nonha/41db0d2/console.html

See the 'heat event-list overcloud' output near the bottom.

[Steven Hardy (shardy)]

Adding heat to this bug. It's been observed that this failure mode is somewhat similar to bug #1423946, but I'm not yet sure if they are actually the same problem.

Trying to reproduce locally to debug further.

[Steven Hardy (shardy)]

I can't currently reproduce this with my local devtest - are you both running with Swift enabled, e.g ObjectStorageCount >0?

If so can you please share your devtestrc so I can test the same config?

[Steven Hardy (shardy)]

https://review.openstack.org/#/c/159059/ proposed to heat

[Dan Prince (dan-prince)]

Steve Hardy: To answer your question the answer is yes. We have swift enabled, and the ObjectStorageCount is 0.

FWIW the temp revert of heat commit f604953 seems to have worked... so that commit appears to be related to the problem.

NOTE: that my inital temprevert test failed because we had magic in our scripts to skip the revert if the bug number was found in the commit message.

[Steven Hardy (shardy)]

> NOTE: that my inital temprevert test failed because we had magic in our scripts to skip the revert if the bug number was found in the commit message.

Ah, that explains why I looked at the logs and it was still failing, that was quite confusing :)

Can we get any clarity on whether https://review.openstack.org/#/c/159059/ resolves the problem without the revert? I stil haven't figured out how to trigger this on my local devtest so haven't been able to test it myself.

[Derek Higgins (derekh)]

CI will run the commit without the temprevert if the commit message contains the bug number. This is the reason we have the "magic" in temprevert that Dan talks about in comment 7.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/159059
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=04e68f87ca0cdb94f47ca156d2363de4932ec911
Submitter: Jenkins
Branch: master

commit 04e68f87ca0cdb94f47ca156d2363de4932ec911
Author: Angus Salkeld <email address hidden>
Date: Wed Feb 25 21:01:12 2015 +1000

    Add ability to pass 0, "", {} or [] as a parameter

    Normal issues with using values as booleans.

    Closes-Bug: #1423946
    Closes-Bug: #1425238
    Co-Authored-by: Sergey Kraynev <email address hidden>
    Co-Authored-by: Angus Salkeld <email address hidden>
    Change-Id: I9c6cd01ca722a65d3de6f28732ae07caefaa6cd8

[Steven Hardy (shardy)]

Is this now resolved?