neutron firewall rule creation not support protocol 'None'

[huangtianhua]

1. create a neutron firewall rule with the template:

****************************************************************
AWSTemplateFormatVersion : 2010-09-09
Description : Template to test neutron firewall rule resource
Resources :
  firewall_rule:
    Type: OS::Neutron::FirewallRule
    Properties:
      name: test-firewall-rule
      shared: True
      action: allow
      enabled: True
      ip_version: 4
****************************************************************

2. the firewall rule is created failed, the reason is:

  "Firewall Rule protocol None is not supported. Only protocol values [None, 'tcp', 'udp', 'icmp'] and their integer representation (0 to 255) are supported."

  seems like neutron not support the string protocol 'None'.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/144264

[Pavlo Shchelokovskyy (pshchelo)]

Using devstack with current master branches of heat, heatclient and neutron I can not reproduce this, stack creates successfully with both the template you show and its HOT version.

[huangtianhua (huangtianhua)]

Sorry for pasting error, missing the protocol: None

****************************************************************
AWSTemplateFormatVersion : 2010-09-09
Description : Template to test neutron firewall rule resource
Resources :
  firewall_rule:
    Type: OS::Neutron::FirewallRule
    Properties:
      name: test-firewall-rule
      shared: True
      action: allow
      enabled: True
      ip_version: 4
      protocol: None
****************************************************************

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/144264
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=c99d3631e013ea518a2b8271f8ccff3e22023aa9
Submitter: Jenkins
Branch: master

commit c99d3631e013ea518a2b8271f8ccff3e22023aa9
Author: huangtianhua <email address hidden>
Date: Mon Dec 29 15:56:20 2014 +0800

    Correct protocol allowed values for firewall rule

    Change protocol allowed values from None to 'any' since
    neutron not allow the string 'None' protocol.

    Change-Id: I06cee893c9aa16c1131cb625ca23c96154de33b3
    Closes-Bug: #1406197