No error if security_group_rule quota is reached

[Pierre Freund]

if Neutron security_group_rule quota is reached, security group is created without the rules, and stack is in CREATE_COMPLETE state.

As for security_group quota, stack should fail if security_group_rule quota is reached.

[Pavlo Shchelokovskyy (pshchelo)]

There is indeed something unexpected happening there. I will investigate further.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/142448

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/142448
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=127d11ac709eee4b9b7cff63c25b76af59b91b0c
Submitter: Jenkins
Branch: master

commit 127d11ac709eee4b9b7cff63c25b76af59b91b0c
Author: Pavlo Shchelokovskyy <email address hidden>
Date: Wed Dec 17 13:56:01 2014 +0000

    Do not ignore OverQuota errors from neutronclient

    Before is_conflict method of out neutron client plugin was checking if
    the error code of the exception raised by neutronclient is 409
    (conflict).

    It fact there are several other exceptions raised by neutronclient
    with the same error code, OverQuotaClient exception included [1], that are
    better to reraise and fail the resource/stack than silently to ignore.

    This patch stops ignoring OverQuota exception specifically.

    [1]
    https://github.com/openstack/python-neutronclient/blob/master/neutronclient/common/exceptions.py#L147

    Change-Id: Iacd3f416e9e651c53c18130f77564d85fd49d7d4
    Closes-Bug: #1403092