assert statement should be removed from heat

[ZhiQiang Fan]

assert should be replaced by testtools.assert* in test code, and replaced by raising exceptions in source code

[Angus Salkeld (asalkeld)]

I agree with the heat/tests/ part, but think there is valid use of it in the code to catch programming error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228348

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228348
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6c4bdc43d931bf38f7d9daad6fccc8c767378d5e
Submitter: Jenkins
Branch: master

commit 6c4bdc43d931bf38f7d9daad6fccc8c767378d5e
Author: Zhiqiang Fan <email address hidden>
Date: Mon Sep 28 02:06:54 2015 -0600

    replace assert statement with unittest.assertXXX

    There are two concerns to do this:

    * assert statement will not be executed when running under optimized
      mode (even though we don't really do this currently)
    * unittest.assertXXX provides more detailed message when test fail,
      for example, assert count == 2 will only have AssertionError, but
      unittest.assertXXX can tell you the test fail because 1 != 2

    This patch replaces assert statement with unittest.assertXXX in our
    test code.

    Note, not all assert statements are replaced because some of them are
    not aiming at the test result.

    Change-Id: Ida44bf6876e6fa60a4d8213f1cdad6edefb34cab
    Closes-Bug: #1397883

[Thierry Carrez (ttx)]

This issue was fixed in the openstack/heat 6.0.0.0b1 development milestone.