RandomString doesn't fail-fast when validating

[Steven Hardy]

RandomString has some class-specific validation, which overrides the base-class validation, such that if you e.g do this:

  HeatTemplateFormatVersion: '2012-12-12'
  Resources:
    secret:
      Type: OS::Heat::RandomString
      Properties:
        length: 513

We don't fail validation before attempting to create the stack, instead failing during stack creation.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/134558

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/134558
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=02c4b2441e12ed12fa58ddd9858b5d91314668ee
Submitter: Jenkins
Branch: master

commit 02c4b2441e12ed12fa58ddd9858b5d91314668ee
Author: Steven Hardy <email address hidden>
Date: Fri Nov 14 15:10:57 2014 +0000

    RandomString don't skip superclass validation

    Ensure the superclass validation happens as well as the class-local
    additional stuff.

    Change-Id: I3fdc6e5d6a4ca741cdd12ca0ed6ceb908c03ae9f
    Closes-Bug: #1392754

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/135666

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/135666
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=1d6dc24f0dd55666bfa77dbc7c34c038d779082d
Submitter: Jenkins
Branch: stable/juno

commit 1d6dc24f0dd55666bfa77dbc7c34c038d779082d
Author: Steven Hardy <email address hidden>
Date: Fri Nov 14 15:10:57 2014 +0000

    RandomString don't skip superclass validation

    Ensure the superclass validation happens as well as the class-local
    additional stuff.

    Change-Id: I3fdc6e5d6a4ca741cdd12ca0ed6ceb908c03ae9f
    Closes-Bug: #1392754
    (cherry picked from commit 02c4b2441e12ed12fa58ddd9858b5d91314668ee)