set secret tag to option stack_domain_admin_password

Bug #1392162 reported by Ethan Lynn
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Ethan Lynn
Juno
Fix Released
Undecided
Unassigned

Bug Description

Currently stack_domain_admin_password is not a secret option in heat codes, and it's value will display in heat log.
https://github.com/openstack/heat/blob/master/heat/common/config.py#L73

Ethan Lynn (ethanlynn)
Changed in heat:
assignee: nobody → Ethan Lynn (ethanlynn)
summary: - set secret tag to option stack_user_admin_password
+ set secret tag to option stack_domain_admin_password
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/134112

Changed in heat:
status: New → In Progress
Steven Hardy (shardy)
Changed in heat:
status: In Progress → Triaged
importance: Undecided → High
milestone: none → kilo-1
Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/134596

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/134112
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=0307d0267713ed18309ecea5359f002d388eaf34
Submitter: Jenkins
Branch: master

commit 0307d0267713ed18309ecea5359f002d388eaf34
Author: Ethan Lynn <email address hidden>
Date: Thu Nov 13 12:46:39 2014 +0800

    Mark stack_domain_admin_password as a secret option

    Add secret=True to option stack_domain_admin_password,
    so that will avoid logging this option in engine.log.

    Closes-Bug: #1392162
    Change-Id: I04071f37a0053b969dc31a69e62ba9abb075c590

Changed in heat:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (stable/juno)

Reviewed: https://review.openstack.org/134596
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=a76ba370e8a8d61dd2363d2fd4c082466166257f
Submitter: Jenkins
Branch: stable/juno

commit a76ba370e8a8d61dd2363d2fd4c082466166257f
Author: Ethan Lynn <email address hidden>
Date: Thu Nov 13 12:46:39 2014 +0800

    Mark stack_domain_admin_password as a secret option

    Add secret=True to option stack_domain_admin_password,
    so that will avoid logging this option in engine.log.

    Closes-Bug: #1392162
    Change-Id: I04071f37a0053b969dc31a69e62ba9abb075c590
    (cherry picked from commit 0307d0267713ed18309ecea5359f002d388eaf34)

tags: added: in-stable-juno
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: kilo-1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.