LaunchConfigurationName needs type validation

[Steven Hardy]

According to a user on IRC, it's possible to refer LaunchConfigurationName to an AWS::EC2::Instance resource, which looking at the code may well work, but probably shouldn't

There's a spec up to add support for the InstanceId property (where this behavior will be desired):

https://review.openstack.org/#/c/130728/

But for LaunchConfigurationName, the AWS docs state you should refer to a AWS::AutoScaling::LaunchConfiguration, so we should probably add some additional validation to ensure the referenced resource is the right type.

[Steven Hardy (shardy)]

Note that until a few days ago, we didn't validate this at all:

https://github.com/openstack/heat/commit/bbe47783b587c6da2ba1a86e332fbd37096005c4

So I guess we just need to add a little more validation in addition to what was implemented in that patch

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/137740

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steve Baker (<email address hidden>) on branch: master
Review: https://review.openstack.org/137740
Reason: This is a very old review which has unaddressed review feedback, failing tests, or merge conflicts.

For this reason it is being abandoned to make the review queue more maintainable. It can be restored and refreshed at any time.