‘remove_event' in ThreadGroupManager declared incompatile with greenthread callback

[Hang Liu]

When updating a stack, the following error occurs,

2014-10-15 09:34:54.664 DEBUG heat.engine.stack_lock [-] Engine 73377f0a-7e45-4e6f-8ab6-2b36867e3d20 released lock on stack 444acfa4-e530-4484-afaa-28a80bcfb021 from (pid=30847) release /opt/stack/heat/heat/engine/stack_lock.py:122
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/hub.py", line 455, in fire_timers
    timer()
  File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/timer.py", line 58, in __call__
    cb(*args, **kw)
  File "/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py", line 219, in main
    self._resolve_links()
  File "/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py", line 230, in _resolve_links
    f(self, *ca, **ckw)
TypeError: remove_event() takes exactly 3 arguments (4 given)

The root cause is,

 remove_event() is declared as,
    def remove_event(self, gt, stack_id, event):
    ... ...

while it is call in _resolve_links() of greenthread
           ... ...

                f, ca, ckw = exit_funcs.popleft()
                f(self, *ca, **ckw)

           ... ...

They are incompatible.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/128580

[OpenStack Infra (hudson-openstack)]

Change abandoned by Hang Liu (<email address hidden>) on branch: master
Review: https://review.openstack.org/128580
Reason: duplicate of https://review.openstack.org/#/c/127096/