Failing tests heat/tests/test_api_openstack_v1.py

[Sergey Kraynev]

I locally start tox and get such traceback:

======================================================================
FAIL: heat.tests.test_api_openstack_v1.InstantiationDataTest.test_format_parse_invalid_message
tags: worker-0
----------------------------------------------------------------------
Traceback (most recent call last):
_StringException: Empty attachments:
  pythonlogging:''
  pythonlogging:'alembic'
  pythonlogging:'cliff'
  pythonlogging:'heat-provision'
  pythonlogging:'iso8601'
  pythonlogging:'keystoneclient'
  pythonlogging:'migrate'
  pythonlogging:'neutronclient'
  pythonlogging:'novaclient'
  pythonlogging:'oslo'
  pythonlogging:'requests'
  pythonlogging:'routes'
  pythonlogging:'saharaclient'
  pythonlogging:'sqlalchemy'
  pythonlogging:'stevedore'
  pythonlogging:'swiftclient'
  pythonlogging:'troveclient'

Traceback (most recent call last):
  File "heat/tests/test_api_openstack_v1.py", line 92, in test_format_parse_invalid_message
    self.assertIn('line 4, column 3', six.text_type(parse_ex))
  File "/home/skr/heat/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 354, in assertIn
    self.assertThat(haystack, Contains(needle), message)
  File "/home/skr/heat/.tox/py27/local/lib/python2.7/site-packages/testtools/testcase.py", line 433, in assertThat
    raise mismatch_error
MismatchError: 'line 4, column 3' not in u'foo not in valid format: while parsing a block mapping\ndid not find expected key\n in "None", line 1, column 1'

It happens after patch b8a5d6611d52c88ad0211caba4e97be0f89bdcd6. (Merge "Switch heat api to oslo i18n")

[Steven Hardy (shardy)]

I've tested latest master, and I can't reproduce this

[Visnusaran Murugan (visnusaran-murugan)]

I get same error. i'm in master (changeId: I2d0250cbb41d79d0210964f7f99c1c6eeeef1257)

[Steve Baker (steve-stevebaker)]

I can reproduce this locally

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/123417

[Pavlo Shchelokovskyy (pshchelo)]

I can not reproduce it on latest master either, and the proposed patch fails on gate exactly due to changes it introduces.

I propose to mark this bug as invalid.

[Visnusaran Murugan (visnusaran-murugan)]

@pshchelo, I happens locally. Traceback suggests it to be "line 1, column 1". Not sure why it happens only in local devstack environment. My master is @ changeId: I2d0250cbb41d79d0210964f7f99c1c6eeeef1257. Fix works locally too. Did try recreating tox?

[Pavlo Shchelokovskyy (pshchelo)]

yep. and the gate agrees with me :)

$ tail -1 /etc/lsb-release
DISTRIB_DESCRIPTION="Ubuntu 14.04.1 LTS"
$ git clone <email address hidden>:openstack/heat.git heat-copy
$ cd heat-copy
$ git log -1
commit 689ea2742e20e08db10ead894e047c5eda3c5754
Author: OpenStack Proposal Bot <email address hidden>
Date: Fri Sep 19 09:16:52 2014 +0000

    Updated from global requirements

    Change-Id: I2d0250cbb41d79d0210964f7f99c1c6eeeef1257
$ tox --version
1.7.2 imported from /usr/local/lib/python2.7/dist-packages/tox/__init__.pyc
$ tox -epy27
....
  py27: commands succeeded
  congratulations :)

BTW I also do not see those ProgrammingErrors from the gate job in my local tests run.

[Thomas Spatzier (thomas-spatzier)]

Hm, I've had this issue in my local env too, even when re-creating the tox env. And the proposed fix helped. But truth seems to be in the gate ...

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/123600

[OpenStack Infra (hudson-openstack)]

Change abandoned by Visnusaran Murugan (<email address hidden>) on branch: master
Review: https://review.openstack.org/123417

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/123600
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=58a094238bbfa4c652d63a000854e77cf894d345
Submitter: Jenkins
Branch: master

commit 58a094238bbfa4c652d63a000854e77cf894d345
Author: Steve Baker <email address hidden>
Date: Wed Sep 24 10:43:44 2014 +1200

    Convert parse error to text type

    Some local environments (but not yet the gate) are experiencing
    failure of InstantiationDataTest.test_format_parse_invalid_message.

    This change fixes that test by converting the parse exception to
    a text type before including it in the error message.

    Change-Id: I06e271559e27452a7a0c1e8807a37bb5ed5df2fa
    Closes-Bug: #1365880