| 2014-09-02 16:48:48 |
Miguel Grinberg |
bug |
|
|
added bug |
| 2014-09-02 16:49:24 |
Miguel Grinberg |
heat: assignee |
|
Miguel Grinberg (miguelgrinberg) |
|
| 2014-09-02 16:50:08 |
Miguel Grinberg |
description |
When validating a template, the heat API returns the "NoEcho" property of template parameters as a string, with values "true" or "false".
But for a client it is odd to have to check this property as a string, and is also error prone, since most people will assume this property comes as a boolean. This happened to me when I was implementing this property on Horizon. I did not realize there were quotes around "true" and "false" in JSON strings until I went with a debugger to inspect why my comparisons were not working right.
Would there be opposition if the API is changed to a return proper JSON boolean for this property? Horizon currently does not use this property at all, so no problems there. I guess the only risk is with other clients, if there are any. |
When validating a template, the heat API returns the "NoEcho" property of template parameters as a string, with values "true" or "false".
But for a client it is odd to have to check this property as a string, and is also error prone, since most people will assume this property comes as a boolean. This happened to me when I was implementing this property on Horizon. I did not realize there were quotes around "true" and "false" in JSON strings until I went with a debugger to inspect why my comparisons were not working right.
Would there be opposition if the API is changed to return proper JSON boolean for this property? Horizon currently does not use this property at all, so no problems there. I guess the only risk is with other clients, if there are any. |
|
| 2014-09-02 16:52:13 |
Miguel Grinberg |
description |
When validating a template, the heat API returns the "NoEcho" property of template parameters as a string, with values "true" or "false".
But for a client it is odd to have to check this property as a string, and is also error prone, since most people will assume this property comes as a boolean. This happened to me when I was implementing this property on Horizon. I did not realize there were quotes around "true" and "false" in JSON strings until I went with a debugger to inspect why my comparisons were not working right.
Would there be opposition if the API is changed to return proper JSON boolean for this property? Horizon currently does not use this property at all, so no problems there. I guess the only risk is with other clients, if there are any. |
When validating a template, the heat API returns the "NoEcho" property of template parameters as a string, with values "true" or "false".
But for a client it is odd to have to check this property as a string, and is also error prone, since most people will assume this property comes as a boolean. This happened to me when I was implementing this property on Horizon. I did not realize there were quotes around "true" and "false" in the JSON responses in the log until I went with a debugger to inspect why my comparisons were not working right.
Would there be opposition if the API is changed to return proper JSON boolean for this property? Horizon currently does not use this property at all, so no problems there. I guess the only risk is with other clients, if there are any. |
|
| 2014-09-02 16:58:22 |
Steven Hardy |
heat: status |
New |
Triaged |
|
| 2014-09-02 16:58:25 |
Steven Hardy |
heat: importance |
Undecided |
Low |
|
| 2014-09-02 17:00:51 |
Steven Hardy |
heat: milestone |
|
ongoing |
|
| 2014-12-02 21:48:27 |
Steve Baker |
heat: importance |
Low |
Wishlist |
|
