docker plugin fails to delete a container resource in CREATE_FAILED state

[Lars Kellogg-Stedman]

The docker plugin (plugin from master, running in stable/icehouse) is unable to delete failed container. Given the following resource:

  docker_dbserver:
    type: "DockerInc::Docker::Container"
    properties:
      image: mysql
      port_specs:
        - 3306
      port_bindings:
        3306: 3306
      env:
        - MYSQL_ROOT_PASSWORD=secret
      name: dbserver

If a container named "dbserver" already exists, the create fails with:

  409 Client Error: Conflict ("Conflict, The name dbserver is already assigned to ff7791c42f29. You have to delete (or rename) that container to be able to assign dbserver to a container again.")

This puts the container into a CREATE_FAILED state:

  $ heat resource-list local
  +-----------------+------------------------------+-----------------+----------------------+
  | resource_name | resource_type | resource_status | updated_time |
  +-----------------+------------------------------+-----------------+----------------------+
  | docker_dbserver | DockerInc::Docker::Container | CREATE_FAILED | 2014-09-01T13:49:58Z |
  +-----------------+------------------------------+-----------------+----------------------+

Trying to delete this stack will result in a new error:

APIError: 404 Client Error: Not Found ("No such container: None")

At this point, the only option is "heat stack-abandon".

[Lars Kellogg-Stedman (larsks)]

Fix proposed in: https://review.openstack.org/#/c/118185/

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lars Kellogg-Stedman (<email address hidden>) on branch: master
Review: https://review.openstack.org/118185
Reason: Jeff has an existing patch that is largely identical.

[LiangChen (hs-chen)]

I'm sorry I make a mistaken change it to Released.